first state of migration done

piel/models/physical/electrical/__init__.py

@@ -0,0 +1,2 @@
+from .types import *
+from .cable import *

piel/models/physical/electrical/cable.py

@@ -4,7 +4,14 @@
 from ..thermal import heat_transfer_1d_W
 from ....materials.thermal_conductivity.types import MaterialReferenceType
 from piel.materials.thermal_conductivity.utils import get_thermal_conductivity_fit
-from .types import *
+from .types import (
+    CoaxialCableGeometryType,
+    CoaxialCableHeatTransferType,
+    CoaxialCableMaterialSpecificationType,
+    DCCableGeometryType,
+    DCCableHeatTransferType,
+    DCCableMaterialSpecificationType,
+)
 from ..types import TemperatureRangeTypes
 
 
@@ -166,8 +173,6 @@ def calculate_dc_cable_geometry(
         length_m=length_m,
         core_cross_sectional_area_m2=core_cross_sectional_area_m2,
         total_cross_sectional_area_m2=total_cross_sectional_area_m2,
-        *args,
-        **kwargs,
     )
 
 

piel/models/physical/electrical/types.py

@@ -15,6 +15,7 @@
 ]
 
 
+# TODO This shouldn't be a quantity
 class CoaxialCableGeometryType(QuantityType):
     core_cross_sectional_area_m2: Optional[float]
     """
@@ -62,6 +63,8 @@ class CoaxialCableHeatTransferType(QuantityType):
     The total computed heat transfer in watts for the cable.
     """
 
+    units: str = "W"
+
 
 class CoaxialCableMaterialSpecificationType(QuantityType):
     core: Optional[MaterialReferenceType]
@@ -112,6 +115,8 @@ class DCCableHeatTransferType(QuantityType):
     The total computed heat transfer in watts for the cable.
     """
 
+    units: str = "W"
+
 
 class DCCableMaterialSpecificationType(QuantityType):
     core: Optional[MaterialReferenceType]

piel/types.py

@@ -9,6 +9,7 @@
 import types
 import numpy as np
 import jax.numpy as jnp
+from typing import Optional
 
 __all__ = [
     "ArrayTypes",
@@ -20,6 +21,7 @@
 ArrayTypes = np.ndarray | jnp.ndarray
 NumericalTypes = int | float | np.dtype | jnp.dtype
 
+
 class PielBaseModel(pydantic.BaseModel):
     class Config:
         arbitrary_types_allowed = True
@@ -34,7 +36,7 @@ class QuantityType(PielBaseModel):
     The base class for all cable types.
     """
 
-    units: str
+    units: Optional[str] = None
     """
     The units of the type.
     """

pyproject.toml

@@ -77,7 +77,7 @@ pydantic = "^2.0"
 pydata-sphinx-theme = {version = ">=0.13.3", optional = true}
 pytest = {version = ">=3.0", optional = true}
 python = ">=3.10,<3.12"
-qutip = "^4.7.3"
+qutip = "^4.7"
 sax = "0.12.2"  # Pinned for pydantic <v2 compatibility.
 scipy = "^1.11.4"
 simple_copied_design = {path = "docs/examples/designs/simple_copied_design", develop = true, optional = true}