Expanded beer categories and styles #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding a note that this is the ITP sandbox version of the README
Used the 2015 BJCP (Beer Judge Certification Program) Style Guidelines. It has 34 overall categories with different specific styles under each one. Link to the guidelines: https://www.bjcp.org/docs/2015_Guidelines_Beer.pdf
removed a final ',' that made the file not pass the checks
Add source to the json object linking to the BJCP 2015 Style Guidelines pdf file
|
Ooops, this is my mistake! @nicolaspe created this pull request for the Open Source Studio class here: Open-Source-Studio-at-ITP#9 I forgot that the extra little change I made to the README in the Would love to know the best way to handle this! |
|
This is all good! Thanks @shiffman and @nicolaspe both. I feel bad for leaving this repo to rust for almost a year but I'm so happy to see all these contributions. |
gilmae
added a commit
to gilmae/corpora
that referenced
this pull request
Jan 28, 2020
* 'master' of https://github.com/dariusk/corpora: (45 commits) Update rpg_games.json Removing duplicate Fix phrasess typo (dariusk#350) Tabletop roleplaying games (files for games, campaign settings and authors) (dariusk#348) Added to carbon allotropes (dariusk#328) Zodiac keywords (dariusk#329) 1017 color names and values from Wikipedia (dariusk#330) Expanded beer categories and styles (dariusk#331) Add egyptian gods (dariusk#332) Add some more details to archetypes/character.json (dariusk#335) Added music genres, one car company and updates to Rock and Roll Hall of Fame (dariusk#334) Add new JSON data lists (dariusk#336) Fix typo, and two entries that were in one (dariusk#337) Small typo correction in strange_words.json (dariusk#338) Adding popular programming languages Added more programming languages (dariusk#347) Removing duplicates Fix list name for consistency with file name/topic (dariusk#340) Add codepage437 (dariusk#342) Create Westworld_quotes.json (dariusk#344) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used the 2015 BJCP (Beer Judge Certification Program) Style Guidelines. It has 34 overall categories with different specific styles under each one.
Link to the guidelines: https://www.bjcp.org/docs/2015_Guidelines_Beer.pdf (in the json file under the "source" category)