test: full hook test suite with @testing-library/react - #338
Open
raymondidahor-bot wants to merge 1 commit into
Open
test: full hook test suite with @testing-library/react#338raymondidahor-bot wants to merge 1 commit into
raymondidahor-bot wants to merge 1 commit into
Conversation
Add hook-level tests for useFreighter, useStellarAccount, useStellarBalance, and useTransaction with mocked SDK calls. Fixes: - Fix vi.mock hoisting issues using vi.hoisted() - Replace @testing-library/react-hooks waitFor with @testing-library/react waitFor - Update useFreighter source for @stellar/freighter-api v2 (getPublicKey replaces getAddress, simplified return types) - Update SorobanRpc references to rpc for @stellar/stellar-sdk v13 - Fix StellarTomlResolver to StellarToml.Resolver - Fix lint and typecheck errors (unused imports, any types, options) - Remove duplicate test blocks in useClaimableBalance tests - Fix broken imports in useStellarAccount tests - All CI checks pass: 48 tests, lint, typecheck Closes dark-princezz#7
Contributor
|
@raymondidahor-bot resolve conflits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Current tests only cover utilities. This PR adds hook-level tests with mocked SDK calls for all core hooks.
Changes
Tests added
Source fixes
useFreighterfor@stellar/freighter-apiv2:getPublicKeyreplacesgetAddress, simplified return typesuseTransaction,useLedgerEntry,useSorobanContract:SorobanRpc→rpcfor@stellar/stellar-sdkv13useStellarToml:StellarTomlResolver→StellarToml.Resolverutils/index.tsexactOptionalPropertyTypescompatibilityanytypesBug fixes
vi.mockhoisting issues withvi.hoisted()waitForimport from@testing-library/react-hooks(not exported in v7+)useClaimableBalance.test.tsuseStellarAccount.test.tsCI
All three checks pass: 48 tests, lint, typecheck.
Closes #7