Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch/curve25519-dalek_fix_to_4.1.1 as the newer breaks build #254

Closed
wants to merge 1 commit into from
Closed

patch/curve25519-dalek_fix_to_4.1.1 as the newer breaks build #254

wants to merge 1 commit into from

Conversation

spital
Copy link
Contributor

@spital spital commented Feb 19, 2024

For latest build ARM/x64

can be used via git apply or patch -p1 from https://github.com/darkrenaissance/darkfi/pull/<<PATCH_NUMBER>>.patch

@aggstam
Copy link
Contributor

aggstam commented Feb 19, 2024

As per living-on-the-cutting-edge, we don't need to make this change, its better to wait for dependencies to fix their versions.
In case its required in some builder, etc, you can follow that steps in its config, like in the gh ci pipelines 1eaf5fa

@aggstam aggstam closed this Feb 19, 2024
@spital
Copy link
Contributor Author

spital commented Feb 20, 2024

Thank you, I'd rather not rely on Microsoft's Github workflows, also these PRs are useful to build dockers:

git checkout master
git pull
git checkout 9f1649e
curl -L https://github.com/darkrenaissance/darkfi/pull/254.patch | git apply -v -
curl -L https://github.com/darkrenaissance/darkfi/pull/253.patch | git apply -v -
curl -L https://github.com/darkrenaissance/darkfi/pull/238.patch | git apply -v -
curl -L https://github.com/darkrenaissance/darkfi/pull/215.patch | git apply -v -

TAG=9f1649ef0__2024-02-17
SHM=196m
ARCH=$(uname -m)
RUST=nightly-2024-02-04

BINS="minerd darkfi-mmproxy darkfid darkirc drk genev genevd lilith swapd taud vanityaddr zkas"

DOCKER_BUILDKIT=0 docker build . --no-cache --pull --shm-size=$SHM --build-arg RUST_VER=${RUST} --build-arg BINS="$BINS" -t darkfi:${ARCH}fedora$TAG -f $DFDIR/Dockerfile.fedora

Maybe I'll try to ping on ircd ;)

@aggstam
Copy link
Contributor

aggstam commented Feb 20, 2024

Hey @spital,
I never said to rely on Microsoft Github workflows, I pointed at them as an example on how to modify your docker building scripts...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants