Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pwstorage] Fix Windows UTF problems #16644

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

zisoft
Copy link
Collaborator

@zisoft zisoft commented Apr 19, 2024

fixes #16603

This windows stuff is driving me nuts 🙂

  • fix windows utf problems
  • allow multiple servers for piwigo
  • code formatting

Thanks to @XavierP56 for testing

@zisoft zisoft added the scope: windows support windows related issues and PR label Apr 19, 2024
@kmilos
Copy link
Contributor

kmilos commented Apr 19, 2024

Note to self: will need to revisit when merging #15899

@zisoft
Copy link
Collaborator Author

zisoft commented Apr 19, 2024

@kmilos: Using UTF-8 locale in general would be great.
I first tried to use the generic Windows functions (CreadWrite instead of CreadWriteA etc.) to let Windows decide automatically but that leads to unreadable entries in the Windows Credential manager: #16603 (comment)

@kmilos
Copy link
Contributor

kmilos commented Apr 19, 2024

I first tried to use the generic Windows functions (CreadWrite instead of CreadWriteA etc.) to let Windows decide automatically

It doesn't do anything automatically, one needs to explicitly convert to/from wchar_t/wstring UCS (UTF-16) to UTF-8 char/string...

Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit added this to the 4.8 milestone Apr 19, 2024
@TurboGit TurboGit added the bugfix pull request fixing a bug label Apr 19, 2024
@TurboGit TurboGit merged commit 799bce4 into darktable-org:master Apr 19, 2024
6 checks passed
@zisoft zisoft deleted the fix-windows-utf branch April 19, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug scope: windows support windows related issues and PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Credential : Piwigo infos not always retrieved.
3 participants