Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gtk error message #18024

Merged
merged 1 commit into from
Dec 28, 2024
Merged

fix gtk error message #18024

merged 1 commit into from
Dec 28, 2024

Conversation

zisoft
Copy link
Collaborator

@zisoft zisoft commented Dec 17, 2024

On some systems the gtk_tree_view_scroll_to_point() causes a Gtk-CRITICAL message.

A forced recompute of the vertical adjustment is a better solution than a forced scroll to the top.
Thanks to @dterrahe for pointing that out.

fixes #18013

@TurboGit TurboGit added this to the 5.0.1 milestone Dec 17, 2024
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit d9f7caa into darktable-org:master Dec 28, 2024
6 checks passed
@TurboGit
Copy link
Member

Merged in master and 5.0.x branch.

@zisoft zisoft deleted the fix-gtk-error branch December 28, 2024 10:40
@zisoft
Copy link
Collaborator Author

zisoft commented Dec 28, 2024

Release notes:

Fixed a scrolling bug in the collections module where the collection tree was not scrolled to the previous position when returning from darkroom.

@TurboGit
Copy link
Member

Thanks!

@TurboGit TurboGit added bugfix pull request fixing a bug and removed release notes: pending labels Dec 28, 2024
@wpferguson
Copy link
Member

Thank you, thank you, thank you....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gtk error messages
3 participants