Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gtk crash on module instance delete #18066

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

zisoft
Copy link
Collaborator

@zisoft zisoft commented Dec 25, 2024

If the currently focused module instance is being deleted, gtk crashes on gtk_widget_grab_focus().

To reproduce:

  • enter darkroom
  • create a new instance of the exposure module
  • slightly touch the exposure slider so the module is focused
  • delete the instance

Solution is to move the focus to dt_ui_center before the module instance is deleted.

fixes #18052
fixes #18039

If the currently focused module instance is being deleted, gtk crashes
on `gtk_widget_grab_focus()`.
@TurboGit TurboGit added this to the 5.0.1 milestone Dec 29, 2024
@TurboGit TurboGit added bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes release notes: pending labels Dec 29, 2024
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit 8855ec9 into darktable-org:master Dec 29, 2024
6 checks passed
@TurboGit
Copy link
Member

Merged in master and 5.0.x branch.

@zisoft zisoft deleted the gtk-instance-delete branch December 29, 2024 21:03
@zisoft
Copy link
Collaborator Author

zisoft commented Dec 30, 2024

Release notes:

Fixed a crash when the currently active module instance is being deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes release notes: pending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

darktable crashes when deleting new instance Darktable 5.1 app crash
2 participants