Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few word spelling corrections #616

Merged
merged 5 commits into from
Apr 20, 2024

Conversation

victoryforce
Copy link
Contributor

No description provided.

@elstoc
Copy link
Contributor

elstoc commented Jan 31, 2024

I think I'd rather say "megapixels" than "MP" or, I guess, "megapixel" in this context

@elstoc elstoc added this to the 4.8 milestone Jan 31, 2024
@victoryforce
Copy link
Contributor Author

There is one generally accepted abbreviation for this term (MP). I saw in the texts both an abbreviated and an unabbreviated version of the term. I don't know which one is stylistically better. But if we don't abbreviate it, then I'm not sure which spelling is correct, because all the combinations of the following variants are found in the texts on the web:

  • someone writes in the singular, someone in the plural
  • someone writes as a capitalized word, someone does not
  • someone writes with a hyphen after the number, someone with a space

Therefore, I'd rather delete the last commit, and you fix the uncommon abbreviation as you think is the most correct in English.

@elstoc
Copy link
Contributor

elstoc commented Jan 31, 2024

For most things, I'd go with an abbreviated term, but MP is (IMO) not the most obvious or commonly used abbreviation (I'm sure it's correct, but Mpx or megapixel just reads better to me) and I'd therefore prefer the unabbreviated term. From an English usage point of view a "24 megapixel sensor" is the correct usage. The alternative "24 megapixels sensor" does not make sense and to use the plural you'd need to modify the sentence to something like "a sensor with 24 megapixels". Up to you if you want to correct here or remove the commit, but I'd rather not use "MP"

@victoryforce
Copy link
Contributor Author

From an English usage point of view a "24 megapixel sensor" is the correct usage.

Great, I'll change the commit accordingly then.

@elstoc elstoc merged commit 38a6d16 into darktable-org:master Apr 20, 2024
1 check passed
@victoryforce victoryforce deleted the words-spelling-fixes branch April 21, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants