Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update variables page with new substitutable EXIF and GPS variables #679

Closed
wants to merge 1 commit into from

Conversation

ralfbrown
Copy link
Contributor

No description provided.

@elstoc
Copy link
Contributor

elstoc commented Sep 24, 2024

Thanks @ralfbrown. Please can you remove the submodule update from this branch, and then I'm happy to merge.

@elstoc
Copy link
Contributor

elstoc commented Sep 24, 2024

Actually no, this will have to wait until we've finalised the 4.8 updates so no hurry.

@elstoc elstoc added this to the 5.0 milestone Sep 24, 2024
@ralfbrown
Copy link
Contributor Author

I don't know how that happened, and when I tried pushing again after a submodule update, git told me everything is up-to-date and refushed to push....

@elstoc
Copy link
Contributor

elstoc commented Sep 24, 2024

Yeah if you look at the commit, it thinks everything is the same, it's just a different commit hash. Maybe squash and rebase? If you can't fix it I'm happy to just rekey this stuff into a new branch when we start merging changes for 5.0

@ralfbrown
Copy link
Contributor Author

I had already tried rebase followed by submodule update, but that indeed did not change the commit hashes. Squashing was successful.

@elstoc
Copy link
Contributor

elstoc commented Sep 24, 2024

Hmm it still seems to think the submodule is updated. Shrug

@ralfbrown
Copy link
Contributor Author

One more variable to add:

$(IMAGE.TAGS.HIERARCHY)    tags list, preserving hierarchy

Your call on whether to rename TAGS to the now-preferred IMAGE.TAGS or make a duplicate entry, since both are still in the autocomplete list.

@ralfbrown
Copy link
Contributor Author

Superceded by 683.

@ralfbrown ralfbrown closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants