Updates to enable SMIL in all versions of IE#1
Open
jonfrost wants to merge 1 commit into
Open
Conversation
…nd FakeSMILe. Also, added support for animation in all versions of IE including IE9 RC. Also, added a new *-smil test page, and updated the index.html file to link to these. You will notice that in the new svg-boilerplate-smil.html file, I actually removed the Shim because IE9 and < IE8 did not like the Shim dynamically loading the FakeSMILe and SVG Web libraries. I was reveiving a variety of errors. Hopefully you can revisit the Shim using this working configuration. I will take another look at the Shim as well when time permits.
|
Any update on this? This patch is almost 2 years old. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Robin,
I updated all of the JS libraries to the latest version: Modernizr, SVG Web, and FakeSMILe.
Also, added support for animation in all versions of IE including IE9 RC.
Also, added a new *-smil test page, and updated the index.html file to link to these.
I tested that the new svg-boilerplate-smil.html file works in the latest version of these browsers:
Opera 11, Firefox 4, Chrome. Also in IE9 RC and IE8.
I did not change your svg-boilerplate.html file, but you will notice that in the new svg-boilerplate-smil.html file, I actually removed the Shim because IE9 and < IE8 did not like the Shim dynamically loading the FakeSMILe and SVG Web libraries. I was reveiving a variety of errors. Hopefully you can revisit the Shim using this working configuration. I will take another look at the Shim as well when time permits.
Best, Jon