refactor: upgrade analysis options

packages/dart_frog/analysis_options.yaml

@@ -1 +1,5 @@
-include: package:very_good_analysis/analysis_options.6.0.0.yaml
+include: package:very_good_analysis/analysis_options.9.0.0.yaml
+linter:
+  rules:
+    # Experimental and there are lots of false positives
+    specify_nonobvious_property_types: false

packages/dart_frog/lib/dart_frog.dart

@@ -1,6 +1,3 @@
-/// A fast, minimalistic backend framework for Dart 🎯
-library dart_frog;
-
 export 'src/_internal.dart'
     show
         Cascade,

packages/dart_frog/lib/src/request_logger.dart

@@ -11,6 +11,7 @@ part of '_internal.dart';
 ///
 /// If [logger] is not passed, the message is just passed to [print].
 Middleware requestLogger({
+  // ignoring to match the shelf.logRequests signature
   // ignore: avoid_positional_boolean_parameters
   void Function(String message, bool isError)? logger,
 }) {

packages/dart_frog/lib/src/router.dart

@@ -322,6 +322,7 @@ class RouterEntry {
     final params = <String>[];
     var pattern = '';
     for (final m in _parser.allMatches(route)) {
+      // avoiding string_buffers to align with shelf_router
       // ignore: use_string_buffers
       pattern += RegExp.escape(m[1]!);
       if (m[2] != null) {
@@ -418,6 +419,7 @@ class RouterEntry {
       }
 
       if (_handler is Handler || _params.isEmpty) {
+        // ignoring to align with shelf_router
         // ignore: avoid_dynamic_calls
         return await _handler(updatedContext) as Response;
       }

packages/dart_frog/pubspec.yaml

@@ -28,7 +28,7 @@ dev_dependencies:
   mocktail: ^1.0.0
   path: ^1.8.2
   test: ^1.19.2
-  very_good_analysis: ">=5.1.0 <7.0.0"
+  very_good_analysis: ^9.0.0
 
 false_secrets:
   - test/src/serve_test.dart

packages/dart_frog/test/src/body_parsers/form_data_test.dart

@@ -1,3 +1,4 @@
+// ignoring for testing purposes
 // ignore_for_file: prefer_const_constructors
 // ignore_for_file: deprecated_member_use_from_same_package
 

packages/dart_frog/test/src/http_method_test.dart

@@ -1,3 +1,4 @@
+// ignoring for testing purposes
 // ignore_for_file: prefer_const_declarations
 
 import 'package:dart_frog/dart_frog.dart';

packages/dart_frog/test/src/provider_test.dart

@@ -64,6 +64,8 @@ void main() {
     Response onRequest(RequestContext context) {
       try {
         context.read<Uri>();
+        // ignoring since we need to catch the StateError for testing
+        // ignore: avoid_catches_without_on_clauses
       } catch (e) {
         exception = e;
       }

packages/dart_frog/test/src/request_logger_test.dart

@@ -1,5 +1,3 @@
-// ignore_for_file: avoid_positional_boolean_parameters
-
 import 'package:dart_frog/dart_frog.dart';
 import 'package:mocktail/mocktail.dart';
 import 'package:test/test.dart';
@@ -10,6 +8,8 @@ void main() {
   group('requestLogger', () {
     var gotLog = false;
 
+    // ignoring to align with shelf logger
+    // ignore: avoid_positional_boolean_parameters
     void logger(String msg, bool isError) {
       expect(gotLog, isFalse);
       gotLog = true;

packages/dart_frog/test/src/response_test.dart

@@ -110,11 +110,7 @@ void main() {
 
       group('bufferOutput', () {
         test('is omitted by default', () {
-          final response = Response.stream(
-            body: const Stream.empty(),
-            // ignore: avoid_redundant_argument_values
-            bufferOutput: true,
-          );
+          final response = Response.stream(body: const Stream.empty());
 
           expect(
             response.context,

packages/dart_frog_auth/analysis_options.yaml

@@ -1 +1,5 @@
-include: package:very_good_analysis/analysis_options.7.0.0.yaml
+include: package:very_good_analysis/analysis_options.9.0.0.yaml
+linter:
+  rules:
+    # Experimental and there are lots of false positives
+    specify_nonobvious_property_types: false

packages/dart_frog_auth/pubspec.yaml

@@ -16,4 +16,4 @@ dependencies:
 dev_dependencies:
   mocktail: ^1.0.0
   test: ^1.19.2
-  very_good_analysis: ^7.0.0
+  very_good_analysis: ^9.0.0