Use pub workspace for the dart-pad monorepo #3041
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
reviewed
Aug 13, 2024
There was a problem hiding this comment.
Looks good generally - good to experiment with this feature. I don't know how this will interact with creating the docker images to run the backend, but I imagine we'll find that out.
In order to get this to work on the CI I think we'll need to provision using the flutter sdk instead of the dart one, given that some of the packages need flutter.
Run dart pub get
Resolving dependencies in `/home/runner/work/dart-pad/dart-pad`...
Because samples depends on flutter from sdk which doesn't exist (the Flutter SDK is not available), version solving failed.
pkgs/dart_services/pubspec.yaml
Outdated
| dependency_overrides: | ||
| dartpad_shared: | ||
| path: ../dartpad_shared | ||
| # This package is managed as part of the dart-pad workspace. |
There was a problem hiding this comment.
As a nit in these files, perhaps move the resolution info to before the dependencies section?
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up a pub workspace for each of the packages in this monorepo. This lets us run
dart pub getfrom the root of the project and take advantage of a shared analysis server.