Removing a requirement in toi_promote which is confusing and unnece…
#4507
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
force-pushed
the
spec_toi_promote_sep25
branch
from
9b4dc17 to
7e79ca7
Compare
eernstg
force-pushed
the
spec_toi_promote_sep25
branch
from
7e79ca7 to
bd138e4
Compare
eernstg
force-pushed
the
spec_toi_promote_sep25
branch
from
bd138e4 to
b7a9977
Compare
stereotype441
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about flow analysis. It removes a condition from a case in the definition of
toi_promotebecause this condition is confusing and unnecessary. For more details look at #4506.