Expose license detection edit operations (incomplete, behind experimental). #9065
+135
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
isoos
commented
Nov 7, 2025
isoos
commented
- Support dual licensing in UI and possibly in search #5359
- Colors and the interactive feature is incomplete (clicking on the removed icon exposes the removed text segment - or a snippet of it).
- Note: the input from pana seems to be not consistent enough for this feature to be useful at this point, but I'd rather have it behind experimental, so that we can better find detection runs where the offsets or operations are off.
Collaborator
Author
|
Note: pushed to staging. |
Contributor
|
This is quite awesome! I found a case where the diff splits in an unlucky place: 
Could we force it to split in "logical" places only (start of sections or something...) This view probably has to be enabled by clicking a button or something... There needs to be more context information given (tool-tips and a color legend, a link to the original licence file we compare with)... Unclear what happens here in the bottom: Would a side-by-side diff view be easier to comprehend? |
sigurdm
approved these changes
Nov 10, 2025
|
|
||
| final _allFlags = <String>{ | ||
| 'dark-as-default', | ||
| 'license', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.