Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated note on arrow notation #5854

Merged
merged 5 commits into from
May 24, 2024
Merged

Updated note on arrow notation #5854

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8728c5e
Updated note on arrow notation
atsansone May 21, 2024
ebcd472
Merge branch 'main' into fix-4582
atsansone May 21, 2024
ced890d
Merge branch 'main' into fix-4582
atsansone May 22, 2024
93e257c
Updated per tech reviews
atsansone May 22, 2024
4229368
Update note per @leafpetersen comment
atsansone May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/content/language/functions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,15 @@ The <code>=> <em>expr</em></code> syntax is a shorthand for
is sometimes referred to as _arrow_ syntax.

:::note
Only an *expression*—not a *statement*—can appear between the arrow (=\>) and
the semicolon (;). For example, you can't put an [if statement][]
there, but you can use a [conditional expression][].
Only _expressions_ can appear between the arrow (`=\>`) and the semicolon (`;`).
Expressions evaluate to values.
This means that you can't write a statement where Dart expects a value.
For example,
you could use a [conditional expression][] but not an [if statement][].
In the previous example,
`_nobleGases[atomicNumber] != null;` returns a boolean value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would take the ; off of here. It's not part of the expression. _nobleGases[atomicNumber] != null is the expression (which produces a value). The ; is a terminator which separates the function declaration from the declaration which follows it.

Also, consider saying "produces a boolean value" or "evaluates to a boolean value" instead of returns, since return is usually associated with a function producing a value (which you capture in the next sentence).

The function then returns a boolean value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function always returns a boolean value. Maybe "The function then returns a boolean value indicating whether or not the atomicNumber..."?

that indicates whether the `atomicNumber` falls into the noble gas range.
:::

## Parameters
Expand Down