-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.6] Add digit separators to Language Tour #6179
base: main
Are you sure you want to change the base?
Conversation
Visit the preview URL for this PR (updated for commit c363979): |
I added Edit: @domesticmouse too if you know the answer (not urgent though) |
Personally I prefer to have PRs failing when they aren't targeting current stable. Makes it obvious that they aren't ready to land |
var n3 = 0x00_14_22_01_23_45; // MAC address | ||
var n4 = 555_123_4567; // US Phone number | ||
var n5 = 100__000_000__000_000; // one hundred million million! | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a version note about the required language version.
There are a few options, including but not limited to:
In this case, I think this is fine to land now if there's a version note, so the easiest solution might be to just drop the excerpt. |
Do not merge until release -- fixes #6144