Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6] Add digit separators to Language Tour #6179

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MaryaBelanger
Copy link
Contributor

Do not merge until release -- fixes #6144

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Oct 29, 2024

Visit the preview URL for this PR (updated for commit c363979):

https://dart-dev--pr6179-digit-separators-j6jad1gq.web.app

@MaryaBelanger
Copy link
Contributor Author

MaryaBelanger commented Oct 29, 2024

I added // ignore_for_file: experiment_not_enabled to pass CI for now, but I guess that didn't do anything. @parlough, when you get a chance, can you remind me the best practice for writing code excerpts for not-yet-released features? (offline works too) Thanks!

Edit: @domesticmouse too if you know the answer (not urgent though)

@domesticmouse
Copy link
Member

Personally I prefer to have PRs failing when they aren't targeting current stable. Makes it obvious that they aren't ready to land

var n3 = 0x00_14_22_01_23_45; // MAC address
var n4 = 555_123_4567; // US Phone number
var n5 = 100__000_000__000_000; // one hundred million million!
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a version note about the required language version.

@parlough
Copy link
Member

parlough commented Oct 31, 2024

I added // ignore_for_file: experiment_not_enabled to pass CI for now, but I guess that didn't do anything. @parlough, when you get a chance, can you remind me the best practice for writing code excerpts for not-yet-released features? (offline works too) Thanks!

There are a few options, including but not limited to:

  1. If the current stable version supports the experiment, you can enable the experiment in that project's analysis config.
  2. If not or the experiment isn't fully functional and you want to land this, not adding a code excerpt for now is fine (but consider creating a TODO or an issue).
  3. If you don't want this to land until the feature is stable, just let the build fail. As Brett mentions that's a good indicator of when support has landed in stable.

In this case, I think this is fine to land now if there's a version note, so the easiest solution might be to just drop the excerpt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document support for digit separators
4 participants