Skip to content

Commit

Permalink
mark flaky windows test as skipped (#2151)
Browse files Browse the repository at this point in the history
See #2150

Also removes an accidental debug print that was landed
  • Loading branch information
jakemac53 authored Dec 5, 2023
1 parent 6e7e4fa commit 03cc56e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
1 change: 0 additions & 1 deletion pkgs/test/lib/src/runner/browser/compilers/dart2wasm.dart
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ class Dart2WasmSupport implements CompilerSupport {
/// A handler that serves wrapper files used to bootstrap tests.
shelf.Response _wrapperHandler(shelf.Request request) {
var path = p.fromUri(request.url);
print(request.url);

if (path.endsWith('.html')) {
var test = '${p.withoutExtension(path)}.dart';
Expand Down
5 changes: 4 additions & 1 deletion pkgs/test/test/runner/compiler_runtime_matrix_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,10 @@ void main() {
expect(test.stdout, emitsThrough('hello'));
expect(test.stderr, emits('world'));
await test.shouldExit(0);
});
},
skip: Platform.isWindows && compiler == Compiler.exe
? 'https://github.com/dart-lang/test/issues/2150'
: null);
}
},
skip: compiler == Compiler.dart2wasm
Expand Down

0 comments on commit 03cc56e

Please sign in to comment.