Add regression test for relative imports in tests under lib
#2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
commented
Dec 5, 2023
natebosch
approved these changes
Dec 5, 2023
Fixes #2142 When a compiler is reading imports it's possible for a relative file import and absolute package import to the same library to get treated as separate libraries. The VM works around this in the case of a `main` under `lib/` by checking when the entrypoint, and only the entrypoint, could be referenced with a `package:` URI so that further relative URIs resolved from that point are consistently treated as `package:` URIs. Use the same workaround for bootstrap files. Add an `absoluteUri` utility in `test_core` which prefers `package:` URIs when feasible, and falls back to absolute file URIs otherwise. When this initial import uses a `package:` URI it will make the subsequent relative imports correctly resolve as `package:` URIs. Add `async` and `await` as necessary since we're currently using the async APIs to read the package config.
|
Oops, I meant to push a new branch and open a PR to pull into this branch, I hadn't intended to push on this branch. Sorry @jakemac53 ! |
This reverts commit 1d80449.
No worries, should I revert or want to land that together with the test? |
I reverted it on this branch. I think we should go ahead and land the test and then handle the fix in a separate PR. |
natebosch
reviewed
Dec 5, 2023
natebosch
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validates the issue listed in #2142.
Skipped for now since it fails in all configurations.