add a pull request labeler; add issue tracker links; update codeowners file #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
commented
Jan 24, 2025
| # These are suggestions; it is fine to have your changes reviewed by someone | ||
| # else. | ||
|
|
||
| /pkgs/checks/ @dart-lang/core-package-admins |
There was a problem hiding this comment.
cc @natebosch and @jakemac53 re: whether these 5 packages match up w/ what you want auto-assigned for review
PR Health |
kevmoo
approved these changes
Jan 24, 2025
Co-authored-by: Kevin Moore <[email protected]>
jakemac53
approved these changes
Jan 24, 2025
Yeah that sounds right to me |
natebosch
approved these changes
Jan 24, 2025
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 27, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. core (https://github.com/dart-lang/core/compare/72a2060..3b35aca): 3b35aca9 2025-01-24 Devon Carew update the topics section of several pubspecs (dart-lang/core#854) ecosystem (https://github.com/dart-lang/ecosystem/compare/682c8ef..c4a163a): c4a163a 2025-01-23 Devon Carew print detailed info about the leaked APIs to stdout in the workflow (dart-lang/ecosystem#339) test (https://github.com/dart-lang/test/compare/7fc9521..92eed6c): 92eed6c4 2025-01-27 Lasse R.H. Nielsen Make zone handlers call zone.run to run callbacks. (dart-lang/test#2451) ad04f172 2025-01-24 Devon Carew add a pull request labeler; add issue tracker links; update codeowners file (dart-lang/test#2452) 1f292db8 2025-01-24 Lasse R.H. Nielsen Don't require Dart 3.5. a56fa947 2025-01-24 Lasse R.H. Nielsen Accept extra `run`s in test. Move to Dart 3.5. 4bd54972 2025-01-24 Lasse R.H. Nielsen Clean-up. Accidentally merged a removed lint back in. 9fa57d16 2025-01-24 Lasse R.H. Nielsen Make zone handlers call zone.run to run callbacks. webdev (https://github.com/dart-lang/webdev/compare/9430dd7..5dc7950): 5dc79508 2025-01-24 Jessy Yameogo Added support for callLibraryMethod with the DDC library bundle format. (dart-lang/webdev#2577) 1d0b32c2 2025-01-24 Srujan Gaddam Reset DWDS to 24.3.4-wip (dart-lang/webdev#2580) 1990d29a 2025-01-23 Srujan Gaddam Implement hot restart for DDC library bundle format and publish 24.3.3 (dart-lang/webdev#2576) Change-Id: Ifa23e74a1399ac7ec70a99750419b915a2efbb19 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406120 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes:
package:test; not sure if this is desired or notissue_tracker:change; I figure that that change will just be picked up with the next general publish of the packagesContribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.