Skip to content

Conversation

@davidmorgan
Copy link
Contributor

@davidmorgan davidmorgan commented Oct 14, 2025

Remove "backup expectations" in tests that were intended to account for matchers sometimes giving different results.

There was a bug on Windows that meant it didn't combine remove+add into modify, it looks like that accounts for a lot of the "backup expectations".

I'm not sure where the others came from: I tried running the tests in a loop on Windows+Linux+MacOS thousands of times after removing the backup expectations and didn't see a single error. So even if they were needed at some point, I don't think they are needed now.

Also remove a startup wait that is no longer needed.

Test failures on MacOS on dev SDK are unrelated, they are due to an SDK issue dart-lang/sdk#61693

@github-actions
Copy link

github-actions bot commented Oct 14, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:bazel_worker 1.1.4 already published at pub.dev
package:benchmark_harness 2.4.0-wip WIP (no publish necessary)
package:boolean_selector 2.1.2 already published at pub.dev
package:browser_launcher 1.1.3 already published at pub.dev
package:cli_config 0.2.1-wip WIP (no publish necessary)
package:cli_util 0.5.0-wip WIP (no publish necessary)
package:clock 1.1.3-wip WIP (no publish necessary)
package:code_builder 4.11.0 already published at pub.dev
package:coverage 1.15.0 already published at pub.dev
package:csslib 1.0.2 already published at pub.dev
package:extension_discovery 2.1.0 already published at pub.dev
package:file 7.0.2-wip WIP (no publish necessary)
package:file_testing 3.1.0-wip WIP (no publish necessary)
package:glob 2.1.3 already published at pub.dev
package:graphs 2.3.3-wip WIP (no publish necessary)
package:html 0.15.7-wip WIP (no publish necessary)
package:io 1.1.0-wip WIP (no publish necessary)
package:json_rpc_2 4.0.0 already published at pub.dev
package:markdown 7.3.1-wip WIP (no publish necessary)
package:mime 2.0.0 already published at pub.dev
package:oauth2 2.0.4 ready to publish oauth2-v2.0.4
package:package_config 2.3.0-wip WIP (no publish necessary)
package:pool 1.5.2 already published at pub.dev
package:process 5.0.5 already published at pub.dev
package:pub_semver 2.2.0 already published at pub.dev
package:pubspec_parse 1.5.1-wip WIP (no publish necessary)
package:source_map_stack_trace 2.1.3-wip WIP (no publish necessary)
package:source_maps 0.10.14-wip WIP (no publish necessary)
package:source_span 1.10.1 already published at pub.dev
package:sse 4.1.8 already published at pub.dev
package:stack_trace 1.12.1 already published at pub.dev
package:stream_channel 2.1.4 already published at pub.dev
package:stream_transform 2.1.2-wip WIP (no publish necessary)
package:string_scanner 1.4.1 already published at pub.dev
package:term_glyph 1.2.3-wip WIP (no publish necessary)
package:test_reflective_loader 0.4.0 already published at pub.dev
package:timing 1.0.2 already published at pub.dev
package:unified_analytics 8.0.6 ready to publish unified_analytics-v8.0.6
package:watcher 1.1.5-wip WIP (no publish necessary)
package:yaml 3.1.3 already published at pub.dev
package:yaml_edit 2.2.2 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
watcher None 1.1.4 1.1.5-wip 1.1.4 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/bazel_worker/benchmark/benchmark.dart
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart
pkgs/boolean_selector/example/example.dart
pkgs/clock/lib/clock.dart
pkgs/clock/lib/src/clock.dart
pkgs/clock/lib/src/default.dart
pkgs/clock/lib/src/stopwatch.dart
pkgs/clock/lib/src/utils.dart
pkgs/clock/test/clock_test.dart
pkgs/clock/test/default_test.dart
pkgs/clock/test/stopwatch_test.dart
pkgs/clock/test/utils.dart
pkgs/coverage/lib/src/coverage_options.dart
pkgs/html/example/main.dart
pkgs/html/lib/dom.dart
pkgs/html/lib/dom_parsing.dart
pkgs/html/lib/html_escape.dart
pkgs/html/lib/parser.dart
pkgs/html/lib/src/constants.dart
pkgs/html/lib/src/encoding_parser.dart
pkgs/html/lib/src/html_input_stream.dart
pkgs/html/lib/src/list_proxy.dart
pkgs/html/lib/src/query_selector.dart
pkgs/html/lib/src/token.dart
pkgs/html/lib/src/tokenizer.dart
pkgs/html/lib/src/treebuilder.dart
pkgs/html/lib/src/utils.dart
pkgs/html/test/dom_test.dart
pkgs/html/test/parser_feature_test.dart
pkgs/html/test/parser_test.dart
pkgs/html/test/query_selector_test.dart
pkgs/html/test/selectors/level1_baseline_test.dart
pkgs/html/test/selectors/level1_lib.dart
pkgs/html/test/selectors/selectors.dart
pkgs/html/test/support.dart
pkgs/html/test/tokenizer_test.dart
pkgs/html/test/trie_test.dart
pkgs/html/tool/generate_trie.dart
pkgs/pubspec_parse/test/git_uri_test.dart
pkgs/stack_trace/example/example.dart
pkgs/watcher/test/custom_watcher_factory_test.dart
pkgs/yaml_edit/example/example.dart

This check can be disabled by tagging the PR with skip-license-check.

@davidmorgan davidmorgan force-pushed the remove-backup-expectations branch 3 times, most recently from 875d578 to c8532c8 Compare October 15, 2025 14:20
@davidmorgan davidmorgan marked this pull request as ready for review October 15, 2025 14:29
@davidmorgan davidmorgan requested a review from a team as a code owner October 15, 2025 14:29
@davidmorgan davidmorgan force-pushed the remove-backup-expectations branch from c8532c8 to 50dd650 Compare October 16, 2025 11:15
Copy link

@chloestefantsova chloestefantsova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Somehow it fell through the cracks.

@davidmorgan davidmorgan force-pushed the remove-backup-expectations branch from b947ec9 to 166c386 Compare October 17, 2025 08:25
@davidmorgan
Copy link
Contributor Author

Thanks!

I added a constant you can tweak to run the test lots of times and set it to 100 as a final check.

There was one failure on MacOS but it's unrelated to the removed backup assertions.

https://github.com/dart-lang/tools/actions/runs/18560153181/job/52906913524?pr=2209

So I think it's solid enough to go in. I set the constant back to 1, I can try to figure out if there's a good way to regularly do more runs another time :)

@davidmorgan davidmorgan merged commit fa978cd into dart-lang:main Oct 17, 2025
18 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Oct 21, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

protobuf (https://github.com/dart-lang/protobuf/compare/14bbd0b..78cf743):
  78cf743  2025-10-20  Ömer Sinan Ağacan  Fix a few extension field bugs (google/protobuf.dart#1062)

tools (https://github.com/dart-lang/tools/compare/f5920a2..d0941a3):
  d0941a35  2025-10-17  Morgan :)  Unify watcher tests (dart-lang/tools#2211)
  fa978cd2  2025-10-17  Morgan :)  Remove backup expectations (dart-lang/tools#2209)

web (https://github.com/dart-lang/web/compare/816abcc..5a7d0be):
  5a7d0be  2025-10-16  Srujan Gaddam  Initial commit of package:js_interop 0.1.0-beta (dart-lang/web#476)

webdev (https://github.com/dart-lang/webdev/compare/2517aa9..82b3855):
  82b38557  2025-10-20  Jessy Yameogo  [DWDS] Fixes hot reload/restart crashes after closing browser tab on web-server device  (dart-lang/webdev#2699)

Change-Id: I98c840892d243f3dc34f9409956d8726ff84238a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/456040
Commit-Queue: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants