-
Notifications
You must be signed in to change notification settings - Fork 76
Remove backup expectations #2209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove backup expectations #2209
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with |
875d578 to
c8532c8
Compare
c8532c8 to
50dd650
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Somehow it fell through the cracks.
b947ec9 to
166c386
Compare
|
Thanks! I added a constant you can tweak to run the test lots of times and set it to 100 as a final check. There was one failure on MacOS but it's unrelated to the removed backup assertions. https://github.com/dart-lang/tools/actions/runs/18560153181/job/52906913524?pr=2209 So I think it's solid enough to go in. I set the constant back to 1, I can try to figure out if there's a good way to regularly do more runs another time :) |
Revisions updated by `dart tools/rev_sdk_deps.dart`. protobuf (https://github.com/dart-lang/protobuf/compare/14bbd0b..78cf743): 78cf743 2025-10-20 Ömer Sinan Ağacan Fix a few extension field bugs (google/protobuf.dart#1062) tools (https://github.com/dart-lang/tools/compare/f5920a2..d0941a3): d0941a35 2025-10-17 Morgan :) Unify watcher tests (dart-lang/tools#2211) fa978cd2 2025-10-17 Morgan :) Remove backup expectations (dart-lang/tools#2209) web (https://github.com/dart-lang/web/compare/816abcc..5a7d0be): 5a7d0be 2025-10-16 Srujan Gaddam Initial commit of package:js_interop 0.1.0-beta (dart-lang/web#476) webdev (https://github.com/dart-lang/webdev/compare/2517aa9..82b3855): 82b38557 2025-10-20 Jessy Yameogo [DWDS] Fixes hot reload/restart crashes after closing browser tab on web-server device (dart-lang/webdev#2699) Change-Id: I98c840892d243f3dc34f9409956d8726ff84238a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/456040 Commit-Queue: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]>
Remove "backup expectations" in tests that were intended to account for matchers sometimes giving different results.
There was a bug on Windows that meant it didn't combine remove+add into modify, it looks like that accounts for a lot of the "backup expectations".
I'm not sure where the others came from: I tried running the tests in a loop on Windows+Linux+MacOS thousands of times after removing the backup expectations and didn't see a single error. So even if they were needed at some point, I don't think they are needed now.
Also remove a startup wait that is no longer needed.
Test failures on MacOS on dev SDK are unrelated, they are due to an SDK issue dart-lang/sdk#61693