-
Notifications
You must be signed in to change notification settings - Fork 77
Fix Linux watcher for entities recently moved between directories #2248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| watcher | Non-Breaking | 1.1.4 | 1.1.5-wip | 1.2.0 Got "1.1.5-wip" expected >= "1.2.0" (non-breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check.
Coverage ⚠️
| File | Coverage |
|---|---|
| pkgs/watcher/lib/src/directory_watcher/directory_list.dart | 💔 68 % ⬇️ 28 % |
| pkgs/watcher/lib/src/directory_watcher/linux.dart | 💔 92 % ⬇️ 0 % |
| pkgs/watcher/lib/src/directory_watcher/mac_os.dart | 💔 0 % ⬇️ NaN % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
Changelog Entry ✔️
| Package | Changed Files |
|---|
Changes to files need to be accounted for in their respective changelogs.
This check can be disabled by tagging the PR with skip-changelog-check.
d8a5818 to
1ab5691
Compare
a54ca2a to
0845aee
Compare
0406215 to
87e623f
Compare
Fix MacOS watcher for recently-created directories.
87e623f to
5f75c36
Compare
Fix #2249
Randomstate before it's copied to the isolateThe improved e2e test also catches an issue on MacOS with races between new directory listing and events. Fix by checking the known emitted state.
The exception fix code at the end of
directory_list.dartwas not handling all error codes, so some types of failure on Windows would be handled incorrectly and not ignored. Copy from the actual SDK code as suggested in the linked issue so it's correct.Tweak CHANGELOG, clarify what the changes affected and sort by it.