Fix 8bitdo Neo Geo Shoulder buttons #942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue with 8bitdo NeoGeo pad shoulder buttons not detected. The 8bitdo Neo Geo Pad is most like their SNES pads with just L1 and R1 shoulder buttons.
|
See #933 while this PR worked to get the trigger as L1/R1 my original objective was to have them on L2/R2 by default. That is now working in latest beta. Thanks for the PR in anycase! |
|
Cool I'll give it a try sometime. A little curious why you wanted them defaulted to L2/R2 when they are digital buttons and they are even labeled L and R just like L1 and R1 on the 8bitdo SN30Pro+ controllers? |
|
the main trigger are In BlueRetro are L2,R2 or LT, RT, or ZL,ZR the top one are the secondary. This keeps things consistent across all systems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#933 Fix issue with 8bitdo NeoGeo pad shoulder buttons not detected. The 8bitdo Neo Geo Pad is most like the 8BitDo SNES pads with just L1 and R1 shoulder buttons. In version 1.8.4 this line didn't exist at all and it just defaulted to default 8bitdo settings. Compiled this locally and tested and it seemed to fix the problem.