This repository was archived by the owner on Mar 13, 2023. It is now read-only.
feat: migrate crab issuing to use pallet!#568
Merged
Conversation
14 tasks
songtianyi
commented
Mar 26, 2021
295c1e7 to
31499d6
Compare
hackfisher
approved these changes
Mar 29, 2021
aurexav
approved these changes
Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #561.
Converts the crab backing pallet to the new pallet attribute macro introduced in #6877.
Upgrade guidelines used.
From checking upgrade guidelines
Common notes
The metadata for CrabIssuing before migration
{ name: CrabIssuing, storage: { prefix: DarwiniaCrabIssuing, items: [ { name: TotalMappedRing, modifier: Default, type: { Plain: MappedRing }, fallback: 0x00000000000000000000000000000000, documentation: [] } ] }, calls: [], events: [ { name: DummyEvent, args: [ AccountId, RingBalance, MappedRing ], documentation: [ Dummy Event. [who, swapped *CRING*, burned Mapped *RING*] ] } ], constants: [ { name: ModuleId, type: ModuleId, value: da/crais, documentation: [] } ], errors: [], index: 33 },The metadata for CrabIssuing after migration
{ name: DarwiniaCrabIssuing, storage: { prefix: DarwiniaCrabIssuing, items: [ { name: TotalMappedRing, modifier: Optional, type: { Plain: MappedRing }, fallback: 0x00, documentation: [] } ] }, calls: [], events: [ { name: DummyEvent, args: [ AccountId, RingBalance, MappedRing ], documentation: [ Dummy Event. [who, swapped *CRING*, burned Mapped *RING*] ] } ], constants: [ { name: ModuleId, type: ModuleId, value: da/crais, documentation: [] } ], errors: [], index: 33 },