Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toXPubBytes(hdkey, opts) #32

Merged
merged 3 commits into from
Jul 15, 2023
Merged

Fix toXPubBytes(hdkey, opts) #32

merged 3 commits into from
Jul 15, 2023

Conversation

coolaj86
Copy link
Member

@coolaj86 coolaj86 commented Jul 15, 2023 •
edited
Loading

There's a bug that toXPubBytes would output the version as xprv rather than xpub.

This fixes that.

It also allows custom version bytes (i.e. TESTNET or whatever).

Discovered while creating dashpay/dips#134

@coolaj86 coolaj86 changed the title Fix toXPubBytes Fix toXPubBytes(hdkey, opts) Jul 15, 2023
@coolaj86 coolaj86 requested a review from jojobyte July 15, 2023 06:00
jojobyte
jojobyte approved these changes Jul 15, 2023
View reviewed changes
Copy link
Contributor

@jojobyte jojobyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coolaj86 coolaj86 merged commit 0866607 into main Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jojobyte jojobyte jojobyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coolaj86 @jojobyte