chore: raise the dashpay Testnet deployment target to 18.0 - #1081
Conversation
Every other build configuration in the project moved to iOS 18 — 23 of the 24 — and this one was left at 17.0. Nothing has needed it: the Podfile has said `platform :ios, '18.0'` for a while, so the pods this configuration links are already built against 18. It surfaced while raising the floor of DashUIKit, which `dashpay` links: a package minimum of iOS 18 makes this the one configuration that cannot link it. Bumping it here first keeps the two in step. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Xcode project raises the DashPay iOS iPhoneOS deployment target from 17.0 to 18.0. ChangesDeployment Target
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The Testnet build minimum rises from iOS 17 to iOS 18 to match the rest of the app and its dependencies; no actionable merge-blocking risk remains beyond normal CI and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🕓 Ready for review — 20 ahead in queue (commit 84ad355) |
llbartekll
left a comment
llbartekll
left a comment
There was a problem hiding this comment.
Reviewed exact head 84ad355. All 24 project deployment-target settings are now iOS 18.0, matching the Podfile. No blockers found.
3 participants
Issue being fixed or feature implemented
The
Testnetconfiguration of thedashpaytarget is the only one in the project still onIPHONEOS_DEPLOYMENT_TARGET = 17.0; the other 23 configurations are 18.0, and the Podfile hasdeclared
platform :ios, '18.0'for a while, so the pods it links are already built against 18.It matters now because DashUIKit is raising its own floor to iOS 18 to match this app
(dashpay/DashUIKit#15).
dashpaylinks that package, so this configuration would be the singleone that fails to build against it — "compiled for iOS 18.0, but linking against target 17.0".
What was done?
One line in
DashWallet.xcodeproj/project.pbxproj:17.0→18.0. All 24 configurations nowagree.
How Has This Been Tested?
Verified by inspection of the project file — after the change no
IPHONEOS_DEPLOYMENT_TARGETbelow 18.0 remains anywhere in it.
Not built locally: a clean checkout needs a full
pod installfirst, and this change cannotaffect anything a 17.0-era build would have compiled differently — every dependency it links is
already built at 18. Worth a CI run on this branch before merging.
Breaking Changes
None for anyone building the app: iOS 18 is already the project's effective minimum. It does
drop the ability to install this specific Testnet configuration on iOS 17 devices, which the
other configurations lost some time ago.
Checklist:
Summary by CodeRabbit