-
Notifications
You must be signed in to change notification settings - Fork 25
feat(dashpay): authorize a token purchase from a DashConnect link #1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
romchornyi
wants to merge
7
commits into
feat/devnet-support
Choose a base branch
from
feat/dashconnect-token-purchase
base: feat/devnet-support
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d84a306
fix(wallet): log the two wallet-startup outcomes added by the SDK
jeanpierreroma 80d8d8b
feat(dashpay): authorize a token purchase from a DashConnect link
jeanpierreroma 43bfabd
fix(dashpay): mark each step of a DashConnect login approval
jeanpierreroma b8a52f1
Merge branch 'feat/devnet-support' into feat/dashconnect-token-purchase
jeanpierreroma 3475838
fix(dashpay): address the token-purchase review — no blind retry, ver…
jeanpierreroma 9dcfea0
fix(dashpay): name the token quantity in its own denomination
jeanpierreroma 57557d7
fix(dashpay): verify the identity after the prompt and the denominati…
jeanpierreroma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 Nitpick: Render the full Platform-credit precision on the approval sheet
Using PlatformCreditsFormatter removes the former eight-fractional-digit limit, but that formatter first converts the UInt64 credits through Double. Executing the current implementation with 10_000_000_000_000_001 credits renders "100000 DASH" instead of "100000.00000000001 DASH", while tokenPurchase receives the exact integer as expectedTotalCost. The switch to an eleven-digit formatter therefore fixes ordinary sub-duff values but does not preserve full credit precision across the accepted range. Use decimal or integer arithmetic in the shared formatter and add boundary assertions against totalPriceDashText; the existing totalPriceDash assertions do not exercise the approval sheet's rendering path.
source: ['claude']