-
Notifications
You must be signed in to change notification settings - Fork 27
[audit][C007] Batched commitment appends omit their accumulated BLAKE3 cost #907
Copy link
Copy link
Open
Labels
area:parsing-costsC groups: decoding, storage accounting, cost estimation and serialization.C groups: decoding, storage accounting, cost estimation and serialization.audit:2026-09Reconciled September 2026 GroveDB audit; audited worktree at 2fa0f133.Reconciled September 2026 GroveDB audit; audited worktree at 2fa0f133.audit:needs-validationSaved source evidence reviewed; focused runtime and deployment validation outstanding.Saved source evidence reviewed; focused runtime and deployment validation outstanding.bugSomething isn't workingSomething isn't workingseverity:low-provisionalLow impact in the audited scenario; provisional static assessment.Low impact in the audited scenario; provisional static assessment.type:correctnessAudit reports incorrect library behavior or accounting without proven security impact.Audit reports incorrect library behavior or accounting without proven security impact.
Description
Activity
Metadata
Metadata
Assignees
Labels
area:parsing-costsC groups: decoding, storage accounting, cost estimation and serialization.C groups: decoding, storage accounting, cost estimation and serialization.audit:2026-09Reconciled September 2026 GroveDB audit; audited worktree at 2fa0f133.Reconciled September 2026 GroveDB audit; audited worktree at 2fa0f133.audit:needs-validationSaved source evidence reviewed; focused runtime and deployment validation outstanding.Saved source evidence reviewed; focused runtime and deployment validation outstanding.bugSomething isn't workingSomething isn't workingseverity:low-provisionalLow impact in the audited scenario; provisional static assessment.Low impact in the audited scenario; provisional static assessment.type:correctnessAudit reports incorrect library behavior or accounting without proven security impact.Audit reports incorrect library behavior or accounting without proven security impact.
Audit group: C007. Classification: correctness. Provisional severity: low.
CommitmentTree::append_many_raw accumulates bulk/final-root BLAKE3 work in a separate hash_count but does not add it to the enclosing OperationCost. Consumers of CostResult therefore miss that work even when the result field is populated. Frontier Sinsemilla costs and the separate hash_count remain available. The audited in-repository callers were tests and seeding/benchmark usage; production fee impact was not established.
Expected contract and correction: Transfer completed BLAKE3 work into the public OperationCost as it occurs, retain incurred costs on error, and preserve the separate result field. Coordinate historical/versioned adoption with downstream cost consumers.
Validation to complete
Limits and existing work
Related tracking: PR #751 (merged), PR #825 (merged), PR #826 (merged).
Scope: saved GroveDB worktree with revision context
2fa0f133877420a0d9c91ba7bc51b1775ab8c783. This report does not establish that currentdevelopor any deployed application is affected. Focused runtime validation remains outstanding.Audit source and canonical finding identifiers
Source status: snapshot-backed (
git_worktree); plain source locations are used because this is not a sealed commit-only scan.Audited revision context:
2fa0f133877420a0d9c91ba7bc51b1775ab8c783.The findings were manually reconciled from a preserved scan bundle. The native scan ended before final completion; these are provisional source-review findings, not a completed native scan certification.
Canonical finding ID:
csf_3d19e9856522a9073785e1ffPrimary fingerprint:
codex-security/v1:sha256:55cee090939981b8387e9b6bd714ba833597805332d839bfeddd3e4f9ec35537Canonical finding ID:
csf_7a6438bf2697a27028337bf7Primary fingerprint:
codex-security/v1:sha256:3b40474a0ff186633b8b2adc713070b7003d7dc987742e110a7de921a5097374Source locations:
grovedb-commitment-tree/src/commitment_tree/mod.rs:425-429grovedb-commitment-tree/src/commitment_tree/mod.rs:466-484grovedb-commitment-tree/src/commitment_tree/mod.rs:519-525grovedb-commitment-tree/src/commitment_tree/mod.rs:535-542grovedb-commitment-tree/src/commitment_tree/mod.rs:329-331grovedb-commitment-tree/src/commitment_tree/mod.rs:418-432grovedb-commitment-tree/src/commitment_tree/mod.rs:479-489grovedb-commitment-tree/src/commitment_tree/mod.rs:519-543