chore: revisit system data contracts #2723
Annotations
10 warnings
|
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
packages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs#L284
warning: unreachable pattern
--> packages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs:284:9
|
284 | _ => Err(Error::Execution(ExecutionError::CorruptedCodeExecution(
| ^
|
= note: `#[warn(unreachable_patterns)]` on by default
|
|
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/documents_batch/data_triggers/triggers/feature_flags/mod.rs#L10
warning: function `create_feature_flag_data_trigger` is never used
--> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/documents_batch/data_triggers/triggers/feature_flags/mod.rs:10:8
|
10 | pub fn create_feature_flag_data_trigger(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/documents_batch/data_triggers/triggers/feature_flags/v0/mod.rs#L35
warning: function `create_feature_flag_data_trigger_v0` is never used
--> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/documents_batch/data_triggers/triggers/feature_flags/v0/mod.rs:35:15
|
35 | pub(super) fn create_feature_flag_data_trigger_v0(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs#L11
warning: module has the same name as its containing module
--> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs:11:1
|
11 | mod update_masternode_identities;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
|
|
packages/rs-drive-abci/src/execution/platform_events/state_transition_processing/process_raw_state_transitions/mod.rs#L40
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> packages/rs-drive-abci/src/execution/platform_events/state_transition_processing/process_raw_state_transitions/mod.rs:40:32
|
40 | raw_state_transitions: &Vec<Vec<u8>>,
| ^^^^^^^^^^^^^ help: change this to: `&[Vec<u8>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
|
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_create/state/v0/mod.rs#L251
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_create/state/v0/mod.rs:251:17
|
251 | &signable_bytes_hasher.hash_bytes().as_slice(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `signable_bytes_hasher.hash_bytes().as_slice()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_top_up/transform_into_action/v0/mod.rs#L178
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_top_up/transform_into_action/v0/mod.rs:178:17
|
178 | &signable_bytes_hasher.hash_bytes().as_slice(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `signable_bytes_hasher.hash_bytes().as_slice()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L494
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:494:223
|
494 | ... new block)", self.current_validator_set_quorum_hash.to_string(), self.validator_sets.keys().into_iter().map(|quorum_hash| quorum_hash...
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
|
|
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L494
warning: useless conversion to the same type: `indexmap::map::Keys<'_, dpp::dashcore::QuorumHash, platform_types::validator_set::ValidatorSet>`
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:494:237
|
494 | ...to_string(), self.validator_sets.keys().into_iter().map(|quorum_hash| quorum_hash.to_string()).join(" | "),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.validator_sets.keys()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
This job succeeded
Loading