Tests #2730
tests.yml
on: workflow_dispatch
Build JS packages
/
Build JS
2m 56s
Matrix: Build Docker images
Determine changed packages
18s
Rust crates security audit
32s
JS dependency versions check
10s
JS NPM security audit
25s
JS code security audit
/
Run Code QL
2m 14s
Packages functional tests
/
Run functional tests
3m 25s
Matrix: Test Suite
Matrix: Dashmate E2E tests
Matrix: JS packages
Matrix: Rust packages
Annotations
5 errors and 169 warnings
JS packages (@dashevo/dapi) / Tests
Process completed with exit code 1.
|
Rust packages (drive) / Tests
Process completed with exit code 101.
|
Test Suite (Test Suite in browser (2), test:browsers, 1, 2) / Run Test Suite in browser (2)
Process completed with exit code 1.
|
Test Suite (Test Suite, test:suite, 0, 0) / Run Test Suite
Process completed with exit code 2.
|
Rust packages (drive-abci) / Tests
The self-hosted runner: ubuntu-platform-arm64_i-0464f3122157f4156 lost communication with the server. Verify the machine is running and has a healthy network connection. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.
|
Determine changed packages
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, dorny/paths-filter@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust crates security audit
The following actions uses Node.js version which is deprecated and will be forced to run on node20: rustsec/audit-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust crates security audit
5 warnings found!
|
Rust crates security audit
Unknown warning kind unsound found, please, file a bug
|
Rust crates security audit
Unknown warning kind unsound found, please, file a bug
|
Rust packages (drive-abci) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust packages (drive-abci) / Unused dependencies
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (dapi-grpc) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust packages (dapi-grpc) / Unused dependencies
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (rs-dapi-client) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust packages (rs-dapi-client) / Unused dependencies
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (dpns-contract) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust packages (dpns-contract) / Unused dependencies
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (dpp) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust packages (dpp) / Unused dependencies
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (drive) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust packages (drive) / Unused dependencies
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (dash-sdk) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust packages (dash-sdk) / Unused dependencies
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (wasm-dpp) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust packages (wasm-dpp) / Unused dependencies
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (random-document) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust packages (random-document) / Unused dependencies
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Build JS packages / Build JS
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update, mozilla-actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS packages (@dashevo/platform-test-suite) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS packages (@dashevo/wallet-lib) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
|
|
|
JS packages (@dashevo/wallet-lib) / Linting:
packages/wallet-lib/src/test/mocks/dashcore/block.js#L33
Unexpected console statement
|
JS packages (@dashevo/dpns-contract) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS packages (dashmate) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS packages (@dashevo/wasm-dpp) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS packages (@dashevo/wasm-dpp) / Linting:
packages/wasm-dpp/test/integration/identity/IdentityFacade.spec.js#L69
Unexpected console statement
|
|
|
|
|
|
|
|
|
JS packages (@dashevo/dapi) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS packages (@dashevo/dapi-client) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS packages (@dashevo/dapi-client) / Linting:
packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L8
Missing JSDoc @Property "network" description
|
JS packages (@dashevo/dapi-client) / Linting:
packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L38
Missing JSDoc @param "options" description
|
JS packages (@dashevo/dapi-client) / Linting:
packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L39
Missing JSDoc @param "createHistoricalSyncStream" description
|
JS packages (@dashevo/dapi-client) / Linting:
packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L40
Missing JSDoc @param "createContinuousSyncStream" description
|
JS packages (@dashevo/dapi-client) / Linting:
packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L63
Missing JSDoc @param "blockHeadersReader" description
|
JS packages (@dashevo/dapi-client) / Linting:
packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L71
Missing JSDoc @param "spvChain" description
|
JS packages (@dashevo/dapi-client) / Linting:
packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L107
Missing JSDoc @param "headers" description
|
|
JS packages (@dashevo/dapi-client) / Linting:
packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L108
Missing JSDoc @param "firstHeaderHeight" description
|
JS packages (@dashevo/dapi-client) / Linting:
packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L108
Missing JSDoc @param "firstHeaderHeight" type
|
JS packages (@dashevo/dapi-grpc) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS packages (@dashevo/dapi-grpc) / Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS packages (@dashevo/dpns-contract) / Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS packages (dashmate) / Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS packages (@dashevo/dapi-client) / Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS packages (dash) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS packages (dash) / Linting:
packages/js-dash-sdk/src/SDK/Client/Client.ts#L10
Dependency cycle via ./Platform:1
|
JS packages (dash) / Linting:
packages/js-dash-sdk/src/SDK/Client/Client.ts#L166
Assignment to function parameter 'options'
|
JS packages (dash) / Linting:
packages/js-dash-sdk/src/SDK/Client/Platform/Fetcher/Fetcher.ts#L143
Returning an awaited value that is not a promise is not allowed
|
JS packages (dash) / Linting:
packages/js-dash-sdk/src/SDK/Client/Platform/Platform.spec.ts#L5
Using exported name 'Client' as identifier for default export
|
JS packages (dash) / Linting:
packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L5
Dependency cycle via ./Platform:10
|
JS packages (dash) / Linting:
packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L5
Using exported name 'Client' as identifier for default export
|
JS packages (dash) / Linting:
packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L8
Dependency cycle detected
|
JS packages (dash) / Linting:
packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L8
Using exported name 'createAssetLockTransaction' as identifier for default export
|
JS packages (dash) / Linting:
packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L10
Dependency cycle detected
|
JS packages (dash) / Linting:
packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L11
Dependency cycle detected
|
JS packages (@dashevo/dapi) / Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS packages (@dashevo/wallet-lib) / Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS packages (@dashevo/wasm-dpp) / Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS code security audit / Run Code QL
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update, github/codeql-action/init@v2, github/codeql-action/analyze@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS code security audit / Run Code QL
CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/
|
Build Docker images (DAPI, dapi, dapi) / Build DAPI image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
|
Build Docker images (DAPI, dapi, dapi) / Build DAPI image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
|
Build Docker images (DAPI, dapi, dapi) / Build DAPI image
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/github-script@v6. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS packages (dash) / Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (dash-sdk) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
unused import: `crate::drive::votes::paths::CONTESTED_DOCUMENT_STORAGE_TREE_KEY`:
packages/rs-drive/src/drive/document/mod.rs#L9
warning: unused import: `crate::drive::votes::paths::CONTESTED_DOCUMENT_STORAGE_TREE_KEY`
--> packages/rs-drive/src/drive/document/mod.rs:9:5
|
9 | use crate::drive::votes::paths::CONTESTED_DOCUMENT_STORAGE_TREE_KEY;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
unused import: `dpp::data_contract::document_type::accessors::DocumentTypeV0Getters`:
packages/rs-drive/src/drive/document/mod.rs#L10
warning: unused import: `dpp::data_contract::document_type::accessors::DocumentTypeV0Getters`
--> packages/rs-drive/src/drive/document/mod.rs:10:5
|
10 | use dpp::data_contract::document_type::accessors::DocumentTypeV0Getters;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `dpp::data_contract::document_type::DocumentTypeRef`:
packages/rs-drive/src/drive/document/mod.rs#L12
warning: unused import: `dpp::data_contract::document_type::DocumentTypeRef`
--> packages/rs-drive/src/drive/document/mod.rs:12:5
|
12 | use dpp::data_contract::document_type::DocumentTypeRef;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `dpp::document::DocumentV0Getters`:
packages/rs-drive/src/drive/document/mod.rs#L15
warning: unused import: `dpp::document::DocumentV0Getters`
--> packages/rs-drive/src/drive/document/mod.rs:15:5
|
15 | use dpp::document::DocumentV0Getters;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `crate::drive::defaults::DEFAULT_HASH_SIZE_U8`:
packages/rs-drive/src/drive/document/paths.rs#L1
warning: unused import: `crate::drive::defaults::DEFAULT_HASH_SIZE_U8`
--> packages/rs-drive/src/drive/document/paths.rs:1:5
|
1 | use crate::drive::defaults::DEFAULT_HASH_SIZE_U8;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `dpp::data_contract::document_type::accessors::DocumentTypeV0Getters`:
packages/rs-drive/src/drive/document/paths.rs#L3
warning: unused import: `dpp::data_contract::document_type::accessors::DocumentTypeV0Getters`
--> packages/rs-drive/src/drive/document/paths.rs:3:5
|
3 | use dpp::data_contract::document_type::accessors::DocumentTypeV0Getters;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `dpp::data_contract::document_type::methods::DocumentTypeV0Methods`:
packages/rs-drive/src/drive/document/paths.rs#L4
warning: unused import: `dpp::data_contract::document_type::methods::DocumentTypeV0Methods`
--> packages/rs-drive/src/drive/document/paths.rs:4:5
|
4 | use dpp::data_contract::document_type::methods::DocumentTypeV0Methods;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `dpp::data_contract::document_type::DocumentTypeRef`:
packages/rs-drive/src/drive/document/paths.rs#L5
warning: unused import: `dpp::data_contract::document_type::DocumentTypeRef`
--> packages/rs-drive/src/drive/document/paths.rs:5:5
|
5 | use dpp::data_contract::document_type::DocumentTypeRef;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
function `contract_documents_primary_key_path` is never used:
packages/rs-drive/src/drive/document/paths.rs#L41
warning: function `contract_documents_primary_key_path` is never used
--> packages/rs-drive/src/drive/document/paths.rs:41:15
|
41 | pub(crate) fn contract_documents_primary_key_path<'a>(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
unused import: `HashSet`:
packages/rs-drive/src/drive/identity/key/fetch/mod.rs#L3
warning: unused import: `HashSet`
--> packages/rs-drive/src/drive/identity/key/fetch/mod.rs:3:29
|
3 | collections::{BTreeMap, HashSet},
| ^^^^^^^
|
Rust packages (dash-sdk) / Check each feature
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (dash-sdk) / Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (dpp) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
taken reference of right operand:
packages/rs-dpp/src/data_contract/document_type/property/mod.rs#L858
warning: taken reference of right operand
--> packages/rs-dpp/src/data_contract/document_type/property/mod.rs:858:20
|
858 | if value == &vec![0] {
| ^^^^^^^^^--------
| |
| help: use the right value directly: `...`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `#[warn(clippy::op_ref)]` on by default
|
taken reference of right operand:
packages/rs-dpp/src/data_contract/document_type/property/mod.rs#L895
warning: taken reference of right operand
--> packages/rs-dpp/src/data_contract/document_type/property/mod.rs:895:20
|
895 | if value == &vec![0] {
| ^^^^^^^^^--------
| |
| help: use the right value directly: `...`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
|
taken reference of right operand:
packages/rs-dpp/src/data_contract/document_type/property/mod.rs#L897
warning: taken reference of right operand
--> packages/rs-dpp/src/data_contract/document_type/property/mod.rs:897:27
|
897 | } else if value == &vec![1] {
| ^^^^^^^^^--------
| |
| help: use the right value directly: `...`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
|
non-canonical implementation of `partial_cmp` on an `Ord` type:
packages/rs-dpp/src/data_contract/document_type/index/mod.rs#L157
warning: non-canonical implementation of `partial_cmp` on an `Ord` type
--> packages/rs-dpp/src/data_contract/document_type/index/mod.rs:157:1
|
157 | / impl PartialOrd for ContestedIndexFieldMatch {
158 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
| | _____________________________________________________________-
159 | || use ContestedIndexFieldMatch::*;
160 | || match (self, other) {
161 | || // Comparing two integers
... ||
170 | || }
171 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
172 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
= note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default
|
`to_string` applied to a type that implements `Display` in `format!` args:
packages/rs-dpp/src/data_contract/document_type/index/mod.rs#L492
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> packages/rs-dpp/src/data_contract/document_type/index/mod.rs:492:66
|
492 | ... e.to_string()
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
|
iterating on a map's values:
packages/rs-dpp/src/data_contract/document_type/v0/random_document_type.rs#L394
warning: iterating on a map's values
--> packages/rs-dpp/src/data_contract/document_type/v0/random_document_type.rs:394:35
|
394 | let indices_json_schema = indices
| ___________________________________^
395 | | .iter()
396 | | .map(|(_, index)| {
397 | | let properties_schema = index
... |
410 | | })
411 | | })
| |______________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map
= note: `#[warn(clippy::iter_kv_map)]` on by default
help: try
|
394 ~ let indices_json_schema = indices.values().map(|index| {
395 + let properties_schema = index
396 + .properties
397 + .iter()
398 + .map(|prop| {
399 + // Only "asc" is allowed for now (v1.0-dev)
400 + json!({ <std::string::String as Clone>::clone(&prop.name): "asc" })
401 + })
402 + .collect::<Vec<_>>();
403 +
404 + json!({
405 + "name": index.name,
406 + "properties": properties_schema,
407 + "unique": index.unique,
408 + })
409 + })
|
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-dpp/src/document/document_factory/v0/mod.rs#L215
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-dpp/src/document/document_factory/v0/mod.rs:215:24
|
215 | let documents: Vec<(
| ________________________^
216 | | DocumentTransitionActionType,
217 | | Vec<(Document, DocumentTypeRef, Bytes32)>,
218 | | )> = documents_iter.into_iter().collect();
| |__________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-dpp/src/document/specialized_document_factory/v0/mod.rs#L223
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-dpp/src/document/specialized_document_factory/v0/mod.rs:223:24
|
223 | let documents: Vec<(
| ________________________^
224 | | DocumentTransitionActionType,
225 | | Vec<(Document, DocumentTypeRef, Bytes32)>,
226 | | )> = documents_iter.into_iter().collect();
| |__________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
module has the same name as its containing module:
packages/rs-dpp/src/identity/mod.rs#L10
warning: module has the same name as its containing module
--> packages/rs-dpp/src/identity/mod.rs:10:1
|
10 | mod identity;
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
|
large size difference between variants:
packages/rs-dpp/src/identity/state_transition/asset_lock_proof/mod.rs#L28
warning: large size difference between variants
--> packages/rs-dpp/src/identity/state_transition/asset_lock_proof/mod.rs:28:1
|
28 | / pub enum AssetLockProof {
29 | | Instant(#[bincode(with_serde)] InstantAssetLockProof),
| | ----------------------------------------------------- the largest variant contains at least 640 bytes
30 | | Chain(#[bincode(with_serde)] ChainAssetLockProof),
| | ------------------------------------------------- the second-largest variant contains at least 40 bytes
31 | | }
| |_^ the entire enum is at least 640 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
29 | Instant(#[bincode(with_serde)] Box<InstantAssetLockProof>),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
|
Build Docker images (Drive, drive, drive-abci) / Build Drive image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
|
Build Docker images (Drive, drive, drive-abci) / Build Drive image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
|
Build Docker images (Drive, drive, drive-abci) / Build Drive image
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/github-script@v6. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
|
Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
|
Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/github-script@v6. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (dpp) / Check each feature
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (dpp) / Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (dapi-grpc) / Check each feature
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (dpns-contract) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (dapi-grpc) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (dpns-contract) / Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (dapi-grpc) / Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (drive) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
unused import: `crate::consensus::basic::data_contract::ContestedUniqueIndexOnMutableDocumentTypeError`:
packages/rs-dpp/src/data_contract/document_type/class_methods/try_from_schema/v0/mod.rs#L27
warning: unused import: `crate::consensus::basic::data_contract::ContestedUniqueIndexOnMutableDocumentTypeError`
--> packages/rs-dpp/src/data_contract/document_type/class_methods/try_from_schema/v0/mod.rs:27:5
|
27 | use crate::consensus::basic::data_contract::ContestedUniqueIndexOnMutableDocumentTypeError;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
using `clone` on type `EstimatedLayerInformation` which implements the `Copy` trait:
packages/rs-drive/src/drive/document/estimation_costs/stateless_delete_of_non_tree_for_costs/v0/mod.rs#L80
warning: using `clone` on type `EstimatedLayerInformation` which implements the `Copy` trait
--> packages/rs-drive/src/drive/document/estimation_costs/stateless_delete_of_non_tree_for_costs/v0/mod.rs:80:39
|
80 | Ok((s as u64, layer_info.clone()))
| ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*layer_info`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive/src/drive/identity/contract_info/keys/mod.rs#L44
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive/src/drive/identity/contract_info/keys/mod.rs:44:10
|
44 | ) -> (
| __________^
45 | | BTreeMap<String, Vec<(KeyID, Purpose)>>,
46 | | Vec<(KeyID, Purpose)>,
47 | | ) {
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive/src/drive/verify/contract/verify_contract/v0/mod.rs#L174
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive/src/drive/verify/contract/verify_contract/v0/mod.rs:174:10
|
174 | ) -> Result<(RootHash, BTreeMap<[u8; 32], Option<DataContract>>), Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive/src/drive/verify/system/verify_elements/v0/mod.rs#L34
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive/src/drive/verify/system/verify_elements/v0/mod.rs:34:10
|
34 | ) -> Result<(RootHash, BTreeMap<Vec<u8>, Option<Element>>), Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive/src/drive/verify/system/verify_elements/mod.rs#L37
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive/src/drive/verify/system/verify_elements/mod.rs:37:10
|
37 | ) -> Result<(RootHash, BTreeMap<Vec<u8>, Option<Element>>), Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
this loop could be written as a `for` loop:
packages/rs-drive/src/drive/verify/voting/verify_vote_poll_vote_state_proof/v0/mod.rs#L97
warning: this loop could be written as a `for` loop
--> packages/rs-drive/src/drive/verify/voting/verify_vote_poll_vote_state_proof/v0/mod.rs:97:17
|
97 | while let Some((path, first_key, element)) = elements_iter.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for (path, first_key, element) in elements_iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
= note: `#[warn(clippy::while_let_on_iterator)]` on by default
|
taken reference of right operand:
packages/rs-drive/src/drive/verify/voting/verify_vote_poll_vote_state_proof/v0/mod.rs#L136
warning: taken reference of right operand
--> packages/rs-drive/src/drive/verify/voting/verify_vote_poll_vote_state_proof/v0/mod.rs:136:32
|
136 | ... if first_key.as_slice() == &RESOURCE_STORED_INFO_KEY_U8_32 {
| ^^^^^^^^^^^^^^^^^^^^^^^^-------------------------------
| |
| help: use the right value directly: `RESOURCE_STORED_INFO_KEY_U8_32`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `#[warn(clippy::op_ref)]` on by default
|
taken reference of right operand:
packages/rs-drive/src/drive/verify/voting/verify_vote_poll_vote_state_proof/v0/mod.rs#L247
warning: taken reference of right operand
--> packages/rs-drive/src/drive/verify/voting/verify_vote_poll_vote_state_proof/v0/mod.rs:247:32
|
247 | ... if first_key.as_slice() == &RESOURCE_STORED_INFO_KEY_U8_32 {
| ^^^^^^^^^^^^^^^^^^^^^^^^-------------------------------
| |
| help: use the right value directly: `RESOURCE_STORED_INFO_KEY_U8_32`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive/src/drive/votes/cleanup/remove_contested_resource_vote_poll_contenders_operations/v0/mod.rs#L20
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive/src/drive/votes/cleanup/remove_contested_resource_vote_poll_contenders_operations/v0/mod.rs:20:21
|
20 | vote_polls: &[(
| _____________________^
21 | | &ContestedDocumentResourceVotePollWithContractInfo,
22 | | &TimestampMillis,
23 | | &BTreeMap<ResourceVoteChoice, Vec<Identifier>>,
24 | | )],
| |__________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
Rust packages (drive-abci) / Check each feature
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (drive-abci) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
module has the same name as its containing module:
packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs#L10
warning: module has the same name as its containing module
--> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs:10:1
|
10 | mod update_masternode_identities;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
packages/rs-drive-abci/src/execution/platform_events/state_transition_processing/process_raw_state_transitions/mod.rs#L40
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> packages/rs-drive-abci/src/execution/platform_events/state_transition_processing/process_raw_state_transitions/mod.rs:40:32
|
40 | raw_state_transitions: &Vec<Vec<u8>>,
| ^^^^^^^^^^^^^ help: change this to: `&[Vec<u8>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive-abci/src/execution/platform_events/voting/clean_up_after_contested_resources_vote_polls_end/v0/mod.rs#L22
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive-abci/src/execution/platform_events/voting/clean_up_after_contested_resources_vote_polls_end/v0/mod.rs:22:21
|
22 | vote_polls: Vec<(
| _____________________^
23 | | &ContestedDocumentResourceVotePollWithContractInfo,
24 | | &TimestampMillis,
25 | | &BTreeMap<ResourceVoteChoice, Vec<Identifier>>,
26 | | )>,
| |__________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive-abci/src/execution/platform_events/voting/clean_up_after_contested_resources_vote_polls_end/mod.rs#L22
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive-abci/src/execution/platform_events/voting/clean_up_after_contested_resources_vote_polls_end/mod.rs:22:21
|
22 | vote_polls: Vec<(
| _____________________^
23 | | &ContestedDocumentResourceVotePollWithContractInfo,
24 | | &TimestampMillis,
25 | | &BTreeMap<ResourceVoteChoice, Vec<Identifier>>,
26 | | )>,
| |__________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive-abci/src/execution/platform_events/voting/clean_up_after_vote_polls_end/v0/mod.rs#L26
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive-abci/src/execution/platform_events/voting/clean_up_after_vote_polls_end/v0/mod.rs:26:34
|
26 | let mut contested_polls: Vec<(
| __________________________________^
27 | | &ContestedDocumentResourceVotePollWithContractInfo,
28 | | &TimestampMillis,
29 | | &BTreeMap<ResourceVoteChoice, Vec<Identifier>>,
30 | | )> = Vec::new();
| |__________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
this expression creates a reference which is immediately dereferenced by the compiler:
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/documents_batch/transformer/v0/mod.rs#L329
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/documents_batch/transformer/v0/mod.rs:329:25
|
329 | &platform.drive,
| ^^^^^^^^^^^^^^^ help: change this to: `platform.drive`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_create/state/v0/mod.rs#L251
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_create/state/v0/mod.rs:251:17
|
251 | &signable_bytes_hasher.hash_bytes().as_slice(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `signable_bytes_hasher.hash_bytes().as_slice()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_top_up/transform_into_action/v0/mod.rs#L178
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_top_up/transform_into_action/v0/mod.rs:178:17
|
178 | &signable_bytes_hasher.hash_bytes().as_slice(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `signable_bytes_hasher.hash_bytes().as_slice()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
`to_string` applied to a type that implements `Display` in `format!` args:
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L519
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:519:223
|
519 | ... new block)", self.current_validator_set_quorum_hash.to_string(), self.validator_sets.keys().into_iter().map(|quorum_hash| quorum_hash...
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
|
useless conversion to the same type: `indexmap::map::Keys<'_, dpp::dashcore::QuorumHash, platform_types::validator_set::ValidatorSet>`:
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L519
warning: useless conversion to the same type: `indexmap::map::Keys<'_, dpp::dashcore::QuorumHash, platform_types::validator_set::ValidatorSet>`
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:519:237
|
519 | ...to_string(), self.validator_sets.keys().into_iter().map(|quorum_hash| quorum_hash.to_string()).join(" | "),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.validator_sets.keys()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
Rust packages (drive) / Tests
This job failure may be caused by using an out of date self-hosted runner. You are currently using runner version 2.316.1. Please update to the latest version 2.317.0
|
Rust packages (drive) / Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (random-document) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
unused import: `crate::consensus::basic::data_contract::ContestedUniqueIndexOnMutableDocumentTypeError`:
packages/rs-dpp/src/data_contract/document_type/class_methods/try_from_schema/v0/mod.rs#L27
warning: unused import: `crate::consensus::basic::data_contract::ContestedUniqueIndexOnMutableDocumentTypeError`
--> packages/rs-dpp/src/data_contract/document_type/class_methods/try_from_schema/v0/mod.rs:27:5
|
27 | use crate::consensus::basic::data_contract::ContestedUniqueIndexOnMutableDocumentTypeError;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
Rust packages (rs-dapi-client) / Check each feature
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (rs-dapi-client) / Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (rs-dapi-client) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (wasm-dpp) / Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (wasm-dpp) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
unused import: `Uint8Array`:
packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs#L21
warning: unused import: `Uint8Array`
--> packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs:21:38
|
21 | use js_sys::{Array, Object, Reflect, Uint8Array};
| ^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
using `clone` on type `Identifier` which implements the `Copy` trait:
packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs#L233
warning: using `clone` on type `Identifier` which implements the `Copy` trait
--> packages/wasm-dpp/src/voting/state_transition/masternode_vote_transition/mod.rs:233:25
|
233 | contested_document_resource_vote_poll.contract_id.clone(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `contested_document_resource_vote_poll.contract_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
module has the same name as its containing module:
packages/wasm-dpp/src/data_contract_factory/mod.rs#L1
warning: module has the same name as its containing module
--> packages/wasm-dpp/src/data_contract_factory/mod.rs:1:1
|
1 | mod data_contract_factory;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
packages/wasm-dpp/src/document/factory.rs#L153
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/wasm-dpp/src/document/factory.rs:153:24
|
153 | let documents: Vec<(
| ________________________^
154 | | DocumentTransitionActionType,
155 | | Vec<(Document, DocumentTypeRef, Bytes32)>,
156 | | )> = documents_by_action
| |__________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
use of a fallible conversion when an infallible one could be used:
packages/wasm-dpp/src/document/factory.rs#L322
warning: use of a fallible conversion when an infallible one could be used
--> packages/wasm-dpp/src/document/factory.rs:322:27
|
322 | let documents_array = js_sys::Array::try_from(documents_with_action)
| ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `From::from`
|
= note: converting `JsValue` to `Array` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
|
you should consider adding a `Default` implementation for `MissingStateTransitionTypeErrorWasm`:
packages/wasm-dpp/src/errors/consensus/basic/state_transition/missing_state_transition_type_error.rs#L21
warning: you should consider adding a `Default` implementation for `MissingStateTransitionTypeErrorWasm`
--> packages/wasm-dpp/src/errors/consensus/basic/state_transition/missing_state_transition_type_error.rs:21:5
|
21 | / pub fn new() -> Self {
22 | | Self {
23 | | inner: MissingStateTransitionTypeError::new(),
24 | | }
25 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
= note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
|
19 + impl Default for MissingStateTransitionTypeErrorWasm {
20 + fn default() -> Self {
21 + Self::new()
22 + }
23 + }
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
packages/wasm-dpp/src/errors/consensus/state/identity/invalid_identity_contract_nonce_error.rs#L34
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> packages/wasm-dpp/src/errors/consensus/state/identity/invalid_identity_contract_nonce_error.rs:34:9
|
34 | *self.inner.setting_identity_contract_nonce() as u64
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*self.inner.setting_identity_contract_nonce()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
implementation of inherent method `to_string(&self) -> String` for type `errors::value_error::PlatformValueErrorWasm`:
packages/wasm-dpp/src/errors/value_error.rs#L29
warning: implementation of inherent method `to_string(&self) -> String` for type `errors::value_error::PlatformValueErrorWasm`
--> packages/wasm-dpp/src/errors/value_error.rs:29:5
|
29 | / pub fn to_string(&self) -> String {
30 | | format!("PlatformValueError: {}", self.message)
31 | | }
| |_____^
|
= help: implement trait `Display` for type `errors::value_error::PlatformValueErrorWasm` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string
= note: `#[warn(clippy::inherent_to_string)]` on by default
|
module has the same name as its containing module:
packages/wasm-dpp/src/identity/mod.rs#L30
warning: module has the same name as its containing module
--> packages/wasm-dpp/src/identity/mod.rs:30:1
|
30 | mod identity;
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
|
module has the same name as its containing module:
packages/wasm-dpp/src/identity/state_transition/identity_create_transition/mod.rs#L4
warning: module has the same name as its containing module
--> packages/wasm-dpp/src/identity/state_transition/identity_create_transition/mod.rs:4:1
|
4 | pub mod identity_create_transition;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
|
Rust packages (random-document) / Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Packages functional tests / Run functional tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Test Suite (Test Suite in browser (2), test:browsers, 1, 2) / Run Test Suite in browser (2)
This job failure may be caused by using an out of date self-hosted runner. You are currently using runner version 2.316.1. Please update to the latest version 2.317.0
|
Test Suite (Test Suite in browser (2), test:browsers, 1, 2) / Run Test Suite in browser (2)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Test Suite (Test Suite in browser (1), test:browsers, 0, 2) / Run Test Suite in browser (1)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Dashmate E2E tests (Testnet fullnode, test/e2e/testnetFullnode.spec.js, false) / Run Testnet fullnode tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Dashmate E2E tests (Testnet Evonode, test/e2e/testnetEvonode.spec.js, false) / Run Testnet Evonode tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Dashmate E2E tests (Local network, test/e2e/localNetwork.spec.js, true) / Run Local network tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Test Suite (Test Suite, test:suite, 0, 0) / Run Test Suite
This job failure may be caused by using an out of date self-hosted runner. You are currently using runner version 2.316.1. Please update to the latest version 2.317.0
|
Test Suite (Test Suite, test:suite, 0, 0) / Run Test Suite
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|