refactor: fees to use version system #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
requested changes
Jun 28, 2024
...drive-abci/src/execution/platform_events/protocol_upgrade/upgrade_protocol_version/v0/mod.rs
Show resolved
Hide resolved
packages/rs-drive/src/drive/credit_pools/epochs/get_epochs_protocol_versions/v0/mod.rs
Show resolved
Hide resolved
packages/rs-platform-version/src/version/fee/data_contract/mod.rs
Outdated
Show resolved
Hide resolved
shumkov
requested changes
Jul 5, 2024
shumkov
previously approved these changes
Jul 5, 2024
QuantumExplorer
requested changes
Jul 12, 2024
packages/rs-platform-version/src/version/fee/state_transition_min_fees/mod.rs
Outdated
Show resolved
Hide resolved
packages/rs-drive/src/drive/credit_pools/epochs/prove_epochs_infos/v0/mod.rs
Outdated
Show resolved
Hide resolved
|
Reviewed, works well, just a few needed changes that are in a future PR. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Some fees needs to be fetched based on the processing
EpochIndex(and not by getting the activePlatformVersion).What was done?
In order to achieve that, a map of
EpochIndex->FeeVersion(on whichEpochtheFeeVersionwere updated) was introduced inPlatformState.upgrade_protocol_version_on_epoch_change, the map is updated only when theFeeVersionis changed.How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only