Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashmate): verify system requirements #1914

Merged
merged 11 commits into from
Jul 9, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jun 28, 2024

Issue being fixed or feature implemented

During a node setup, dashmate should verify and suggest minimal system requirements to users

What was done?

  • Verify minimal system requirements in dashmate setup command: CPU, RAM, free disk space

How Has This Been Tested?

Running dashmate setup locally

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.0.0 milestone Jun 28, 2024
Copy link
Collaborator

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shumkov I left a few suggestions. All pretty minor stuff

pshenmic
pshenmic previously approved these changes Jul 9, 2024
…quirements

# Conflicts:
#	packages/dashmate/src/createDIContainer.js
#	packages/dashmate/src/listr/tasks/setup/setupRegularPresetTaskFactory.js
@shumkov shumkov merged commit de883f9 into v1.0-dev Jul 9, 2024
21 checks passed
@shumkov shumkov deleted the feat/dashmate/verifyMinimalRequirements branch July 9, 2024 14:49
thephez added a commit to thephez/dash-user-docs that referenced this pull request Jul 16, 2024
thephez added a commit to dashpay/docs that referenced this pull request Jul 17, 2024
* docs: remove manual evonode setup

These instructions were for Core-only evonodes which are going away with Platform's launch

* docs: remove details not required when doing DMT or dashmate setup

* docs: add callout about payout address

* docs: add evonode requirements based on dashmate checks

Requirements from: dashpay/platform#1914

* docs: minor reword

* docs: update firewall info

* docs: update mn/en table and description

* docs: add warning and minimize core collateral storage by default

* docs: minor cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants