Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): support mocking of error responses #1926

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Jul 4, 2024

Issue being fixed or feature implemented

We are not able to run offline tests (without network connectivity, eg. errors) as we don't support serialization of errors.

What was done?

Implemented Mockable for Result<T,E> and for DapiClientError.

How Has This Been Tested?

Locally, generated test vectors.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek marked this pull request as ready for review July 4, 2024 15:43
@lklimek lklimek merged commit bedcde3 into feat/contestedDocumentResolutionWithMasternodeVoting Jul 4, 2024
50 of 59 checks passed
@lklimek lklimek deleted the test/mn-voting-offline-testing branch July 4, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants