Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sdk): disable failing tests for bugs scheduled for future #1930

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Jul 5, 2024

Issue being fixed or feature implemented

The following tests fail, and we decided they will be fixed in separate PRs:

  • fetch::contested_resource::contested_resources_fields::exact_match_query_returns_one_object_plan_656
  • fetch::contested_resource::contested_resources_fields::start_at_value_wrong_index_type_returns_invalidargument_plan_653
  • fetch::contested_resource::contested_resources_limit_PLAN_656
  • fetch::contested_resource_vote_state::contested_resource_vote_states_with_limit_PLAN_674
  • fetch::document::document_list_bug_value_text_decode_base58_PLAN_653

What was done?

Disabled tests with comment disabled due to bug...

How Has This Been Tested?

GHA: https://github.com/dashpay/platform/actions/runs/9810199925

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer merged commit 239371c into feat/contestedDocumentResolutionWithMasternodeVoting Jul 5, 2024
87 of 92 checks passed
@QuantumExplorer QuantumExplorer deleted the test/disable-tests-for-non-fixed-items branch July 5, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants