Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: where clauses recognize nested properties #2035

Merged
merged 9 commits into from
Aug 21, 2024

Conversation

pauldelucia
Copy link
Member

@pauldelucia pauldelucia commented Aug 2, 2024

Issue being fixed or feature implemented

When building queries with WHERE clauses, by using document type properties field rather than flattened_properties, we weren't accounting for nested properties

What was done?

Use flattened_properties instead of properties

How Has This Been Tested?

Platform TUI

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pauldelucia pauldelucia changed the base branch from v1.0-dev to v1.1-dev August 15, 2024 10:04
ogabrielides
ogabrielides previously approved these changes Aug 19, 2024
Copy link
Contributor

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pauldelucia pauldelucia merged commit 55da39f into v1.1-dev Aug 21, 2024
35 of 36 checks passed
@pauldelucia pauldelucia deleted the fix/sql-queries-on-nested-properties branch August 21, 2024 07:46
@thephez thephez added this to the v1.1.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants