feat(dashmate)!: enhance core logging configuration #2121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Dashmate enables core logging into file by default. Users do not expect it and not aware of this file. Furthermore, the log file is growing in size quite fast and might crash node taking all available disk space.
What was done?
sourceLocations
,threadNames
,timeMicros
, andexclude
optionsHow Has This Been Tested?
Running locally and CI
Breaking Changes
core.log.file.path
changed tocore.log.filePath
core.log.file.categories
changed tocore.log.debug.includeOnly
core.logIps
changed tocore.log.debug.ips
Checklist:
For repository code-owners and collaborators only