Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(dapi): better api for identities balances #2122

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

QuantumExplorer
Copy link
Member

@QuantumExplorer QuantumExplorer commented Sep 15, 2024

Issue being fixed or feature implemented

The previous API requires to pass a double structured list, this PR simplifies things.

What was done?

Changed the API to make it more friendly.

How Has This Been Tested?

Breaking Changes

Not breaking compared to previous version.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer added this to the v1.3.0 milestone Sep 15, 2024
@QuantumExplorer QuantumExplorer added the dapi-endpoint DAPI endpoint addition or modification label Sep 15, 2024
@QuantumExplorer QuantumExplorer self-assigned this Sep 15, 2024
@QuantumExplorer QuantumExplorer merged commit e703f7e into v1.3-dev Sep 16, 2024
58 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/betterApiForIdentitiesBalances branch September 16, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dapi-endpoint DAPI endpoint addition or modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant