Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drive-abci): require 75 percent of active, not total hpmns #2127

Merged
merged 2 commits into from
Sep 16, 2024
Merged

fix(drive-abci): require 75 percent of active, not total hpmns #2127

merged 2 commits into from
Sep 16, 2024

Conversation

QuantumExplorer
Copy link
Member

@QuantumExplorer QuantumExplorer commented Sep 16, 2024 •
edited
Loading

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

This is a breaking change.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

ktechmidas
ktechmidas previously approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@ktechmidas ktechmidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuantumExplorer QuantumExplorer changed the title fix: require 75 percent of active, not total hpmns fix(drive-abci): require 75 percent of active, not total hpmns Sep 16, 2024
shumkov
shumkov approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit a434090 into v1.3-dev Sep 16, 2024
10 of 16 checks passed
@shumkov shumkov deleted the fix/require75pOfActiveNotTotalHPMNs branch September 16, 2024 16:09
@shumkov shumkov mentioned this pull request Sep 16, 2024
Merged
6 tasks
@thephez thephez added this to the v1.3.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@ktechmidas ktechmidas ktechmidas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@QuantumExplorer @shumkov @ktechmidas @thephez