-
Notifications
You must be signed in to change notification settings - Fork 59
perf(drive-abci): remove historical withdrawal status diagnostic #4569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
05403a9
perf(drive-abci): don't read every withdrawal document to build a deb…
PastaPastaPasta efd398d
fix(drive-abci): keep the withdrawal status summary from failing a block
PastaPastaPasta cf5e8e4
test(drive-abci): drop the empty-history withdrawal summary test
PastaPastaPasta edf1fa4
perf(drive-abci): remove withdrawal status diagnostic
PastaPastaPasta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Blocking: Do not change active versioned block-execution behavior in place
pool_withdrawals_into_transactions_queue_v1is selected from protocol v5 onward, including v14 throughDRIVE_ABCI_METHOD_VERSIONS_V10, while the v0 implementation can also delegate to it. This therefore changes behavior for already-defined protocol versions. More importantly,fetch_oldest_withdrawal_documentscalls the falliblequery_documentspath and previously propagated its error unconditionally; after this guard, the same block and state can returnOk(())on a node without DEBUG tracing while a DEBUG-enabled node or older binary still executes the query and can fail. The successful app-hash replay confirms the normal path but does not cover this changed failure behavior. Keep v0/v1 frozen, introduce a v2 implementation selected at a protocol activation boundary, and make its purely diagnostic query non-fatal so tracing configuration cannot affect block-execution success.source: ['claude']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partially addressed in
efd398de: the diagnostic fetch is no longer fatal. A Drive error infetch_oldest_withdrawal_documentsis logged at DEBUG and the method returnsOk(()), so block outcome no longer depends on the log level. Verified on headcf5e8e4a.The question of whether this needs a v2 method version rather than an in-place edit to
pool_withdrawals_into_transactions_queue_v1is left for the maintainer to decide; this thread stays open for that.🤖 Posted autonomously by Claude on behalf of pasta.