Skip to content

ci: wake PR Hygiene only for a comment that can change the answer - #4783

Merged
shumkov merged 1 commit into
v4.3-devfrom
chore/pr-hygiene-decisive-comments-v4.3-dev
Sep 16, 2026
Merged

shumkov merged 1 commit into
v4.3-devfrom
chore/pr-hygiene-decisive-comments-v4.3-dev

Conversation

@shumkov

@shumkov shumkov commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Re-pins the shared review workflow onto dashpay/stale_prs_are_bad#30, and narrows which comments start a run.

Every comment by either review bot used to start a full reconciliation. Measured over 75 recent pull requests:

receipts via review receipts via comment
coderabbitai 0 19
thepastaclaw 15

CodeRabbit never approves, so its comments must still be heard — but only for the two markers the engine reads: its completion receipt and its rate-limit notice. thepastaclaw always reports by review, which arrives on its own event, and nothing reads its comments at all; it posted them on 67 of those pull requests, each one a reconciliation over data no rule consults.

This costs latency and never correctness: comments are read from the pull request when a run happens, not from the event that started it, so a comment that starts no run is still seen by the next one and by the hourly sweep. Every trigger condition is a strict superset of the engine rule it guards.

Note for anyone reading the workflow: the two marker strings are generated from the engine's own constants rather than written out here, so they cannot drift apart.

No change to who may approve, when a pull request is ready, or what blocks it.

🤖 Generated with Claude Code

Every comment by either review bot started a full reconciliation. CodeRabbit
receipt is a comment and has to be heard; thepastaclaw is a review, which
arrives on its own event, and nothing reads its comments.

dashpay/stale_prs_are_bad#30 landed as 17ce8d20f2ba1ac7103d01fcf2aea15ac7f1c01f.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: e924b43b-ccb0-4f40-8442-7c5fce73fa83

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added this to the v4.3.0 milestone Sep 16, 2026
@shumkov
shumkov merged commit 56a5f7f into v4.3-dev Sep 16, 2026
18 checks passed
@shumkov
shumkov deleted the chore/pr-hygiene-decisive-comments-v4.3-dev branch September 16, 2026 19:16
@thepastaclaw

thepastaclaw commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

🕓 Queued for automated review — 16th in line, estimated start in ~4 h (commit bae1c41)
Estimated review time once started: ~35 min (two-phase automated review; median of recent runs).

  • Request priority review — click to move this review to the front of the queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants