ci: re-pin PR Hygiene to clone this repository only on its sweep - #4786
Merged
Merged
Conversation
The clone of this repository was the slowest step in every run, nine of its twenty seconds, and it answers one question: do the policy area directories still exist. That can only change when a pull request merges, and the sweep asks every hour. dashpay/stale_prs_are_bad#31 landed as 6d57d4c22eeeeaff88554f6e78466be2aec7aed7. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-pins the shared review workflow onto dashpay/stale_prs_are_bad#31.
Every run cloned this repository's default branch. Measured across four consecutive platform runs it was 8–10 seconds of a 20–26 second run — the slowest step by some way, against 4–5 seconds for the reconciliation it supports.
It exists to answer one question: do the directories the policy names still exist? That can only change when a pull request merges. The policies are already checked against a fresh clone of every governed repository whenever one is proposed, and the sweep asks again every hour — so the clone now happens on the scheduled sweep, a manual dispatch, or a push to the default branch, and not on ordinary pull request events.
Two things worth knowing:
The advisory "policy paths and CODEOWNERS" summary was always generated from the default branch, never from the pull request's head, so a pull request editing CODEOWNERS always got the same answer the sweep gives. That feedback loses latency, not information.
No change to who may approve, when a pull request is ready, or what blocks it.
🤖 Generated with Claude Code