ci: re-pin PR Hygiene to require a green build before asking a human - #4796
Merged
Merged
Conversation
A pull request now has to be green before reviewers are requested, and a build that goes red afterwards does not take that back. A second schedule looks again at the pull requests waiting on a build, because a build turning green raises no event this controller hears. dashpay/stale_prs_are_bad#32, #33 and #34 landed as 176b4072cb93c69a19c68ebdda2080b5ec12bea3. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-pins the shared review workflow onto dashpay/stale_prs_are_bad#32, #33 and #34.
A green build before a human is asked. Reviewers are requested once the build is green; a build that goes red afterwards does not take it back, so a flaky test cannot withdraw a review request already sent or drop its author out of a review slot. A new push starts the cycle again, as it already does for the bots and the attestation.
Only the newest run of each check counts — re-running a check adds a run beside the old one rather than replacing it, so a head keeps every failed attempt for ever and GitHub's own rollup reads FAILURE on pull requests whose every check has since passed. Cancelled is not a failure. A repository with no checks is green.
A second schedule, three times an hour, reconciles only the pull requests already recorded as waiting on a build — because a build turning green raises no event this controller subscribes to. It costs two requests when nothing is waiting, and does nothing at all where this controller does not write.
One less thing to read. The state comment asked for the self-review attestation three times over; it asks once now. Naming a commit explicitly still works, it is simply no longer advertised.
No change to who may approve, or to the five-slot queue.
🤖 Generated with Claude Code