Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore arg-type error in CLI functions #7985

Closed
wants to merge 1 commit into from

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jul 11, 2023

Since click 8.1.4, mypy fails to deduce the correct types in the click type annotations for click.command. See pallets/click#2558 and python/mypy#13449.

For now, workaround by ignoring the arg-type error.

  • Tests added / passed
  • Passes pre-commit run --all-files

Since click 8.1.4, mypy fails to deduce the correct types in the click
type annotations for click.command. See pallets/click#2558 and
python/mypy#13449.

For now, workaround by ignoring the arg-type error.
@wence- wence- requested a review from fjetter as a code owner July 11, 2023 13:47
@wence- wence- mentioned this pull request Jul 11, 2023
2 tasks
@hendrikmakait hendrikmakait self-requested a review July 11, 2023 13:54
@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       20 files  ±0         20 suites  ±0   11h 44m 9s ⏱️ + 22m 31s
  3 708 tests ±0    3 594 ✔️  - 5     106 💤 ±0  8 +5 
35 866 runs  ±0  34 110 ✔️  - 3  1 748 💤  - 2  8 +5 

For more details on these failures, see this check.

Results for commit e1df545. ± Comparison against base commit 722414f.

@hendrikmakait
Copy link
Member

Thanks for investigating and creating a fix, @wence-. @graingert created a concurrent fix in #7989 that does not touch code files, so I am closing this one as superseded by #7979.

@wence- wence- deleted the wence/fix/mypy branch July 12, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants