Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dask order uses task_spec #8842

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Aug 26, 2024

This builds on #8797

The relevant commit is 919ff4f

This removes the need to materialize and copy the dependencies to a dict.

Needs dask/dask#11347

Copy link
Contributor

github-actions bot commented Aug 26, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    18 files   -      7      18 suites   - 7   6h 55m 23s ⏱️ - 3h 14m 4s
 4 114 tests  -      8   3 856 ✅  -    150    114 💤 +  3  143 ❌ +138  1 🔥 +1 
34 449 runs   - 13 166  32 406 ✅  - 13 095  1 602 💤  - 506  439 ❌ +433  2 🔥 +2 

For more details on these failures and errors, see this check.

Results for commit 0ef6e89. ± Comparison against base commit 2e61816.

This pull request removes 10 and adds 2 tests. Note that renamed tests count towards both.
distributed.tests.test_client ‑ test_persist_get
distributed.tests.test_client ‑ test_recreate_error_array
distributed.tests.test_client ‑ test_recreate_error_collection
distributed.tests.test_client ‑ test_recreate_error_delayed
distributed.tests.test_client ‑ test_recreate_error_futures
distributed.tests.test_client ‑ test_recreate_task_array
distributed.tests.test_client ‑ test_recreate_task_collection
distributed.tests.test_client ‑ test_recreate_task_delayed
distributed.tests.test_client ‑ test_recreate_task_futures
distributed.tests.test_utils ‑ test_maybe_complex
distributed.tests.test_client ‑ test_persist_get[False]
distributed.tests.test_client ‑ test_persist_get[True]
This pull request skips 3 tests.
distributed.shuffle.tests.test_merge ‑ test_minimal_version
distributed.tests.test_client ‑ test_computation_object_code_not_available
distributed.tests.test_worker_client ‑ test_submit_different_names

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant