Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url escaping on exceptions dashboard for non-string keys #8891

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

phofl
Copy link
Collaborator

@phofl phofl commented Oct 15, 2024

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

@phofl phofl requested a review from fjetter as a code owner October 15, 2024 09:24
@phofl
Copy link
Collaborator Author

phofl commented Oct 15, 2024

Here is a reproducer that raised previously:

if __name__ == "__main__":
    cluster = LocalCluster()
    client = cluster.get_client()
    print(cluster.dashboard_link)

    def test(i):
        raise NotImplementedError

    res = client.submit(test, 10, key=1)

    time.sleep(100)

@fjetter fjetter merged commit 9bec841 into dask:main Oct 15, 2024
23 of 30 checks passed
@phofl phofl deleted the url-escaping branch October 15, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants