Implementation of Byte Size and Time Duration Parsing with AggregateStats Directive #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support for parsing and handling byte sizes and time durations, along with a new AggregateStats directive. The changes include new classes for byte size and time duration parsing, modifications to the grammar and token types, and comprehensive test coverage. The implementation follows Java 8 standards and project conventions, providing robust error handling and unit conversion capabilities. Description: Implementation of Byte Size and Time Duration Parsing with AggregateStats Directive Changes Made: 1. Added support for parsing byte sizes (KB, MB, GB, TB, PB) and time durations (ns, ms, s) 2. Created new classes: - ByteSize.java: Handles byte size parsing and conversion - TimeDuration.java: Handles time duration parsing and conversion - AggregateStats.java: Implements the aggregation directive - AggregateStatsTest.java: Comprehensive test coverage 3. Modified existing files: - TokenType.java: Added BYTE_SIZE and TIME_DURATION types - Directives.g4: Added grammar rules for byte size and time duration parsing Key Features: - Robust parsing of byte sizes and time durations - Proper error handling for invalid formats - Unit conversion support - Comprehensive test coverage - Follows Java 8 standards and project conventions The implementation allows users to: - Parse and convert between different byte size units - Parse and convert between different time duration units - Aggregate statistics based on size and time columns Implementation of Byte Size and Time Duration Parsing with AggregateStats Directive Changes Made: 1. Added support for parsing byte sizes (KB, MB, GB, TB, PB) and time durations (ns, ms, s) 2. Created new classes: - ByteSize.java: Handles byte size parsing and conversion - TimeDuration.java: Handles time duration parsing and conversion - AggregateStats.java: Implements the aggregation directive - AggregateStatsTest.java: Comprehensive test coverage 3. Modified existing files: - TokenType.java: Added BYTE_SIZE and TIME_DURATION types - Directives.g4: Added grammar rules for byte size and time duration parsing Key Features: - Robust parsing of byte sizes and time durations - Proper error handling for invalid formats - Unit conversion support - Comprehensive test coverage - Follows Java 8 standards and project conventio
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Added proper JavaDoc documentation for: - BYTE_SIZE enum value with examples of byte size units - TIME_DURATION enum value with examples of time duration units
Added comprehensive test coverage: - ByteSizeTest.java: Tests for byte size parsing and conversion - TimeDurationTest.java: Tests for time duration parsing and conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation adds support for parsing and handling byte sizes and time durations in the Wrangler library. The changes include:
New Classes:
Modified Files:
Key Features:
The implementation allows users to: