Fixing Linter Issues #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* first try * spike: spade-traverse separate file * revert: bitswap.go * spike: working test retrieve & decode * feat: extract findLinks fn * spike: extract out SpadeTraversal * spike: cleanup * docs: add comment * spike: rename * refactor: errors.Wrap * fix: PR comments * fix: typo * spike: fix for root node with only one link * feat: merge spike code into bitswap.go * feat: spade traversal - return retrievalResult * feat: wire up SpadeTraversal to bs worker * chore: cleanup, comments * docs: update comment * fix: resolve bsw client timeout issue * cleanup: remove unused retrieve_size * cleanup: use BitswapClient instead of creating new * fix: FindLinks return empty array * feat: rework traverse_depth -> max_traverse_depth --------- Co-authored-by: Jason Cihelka <[email protected]>
|
These were found in the spade repo but I would assume they should be fixed here as well. |
|
Realized there are spade change in here now. We will have to fix the issues separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a few of the linter issues so we can get the build.yml to work