Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate service worker channels and goroutines #417

Merged
merged 11 commits into from
Nov 9, 2023

Conversation

gammazero
Copy link
Collaborator

Instead of having every service worker report a failure error and the done status of each goroutine within the service, use a single channel to have all service report on their status and completion.

Fixes #415

Instead of having every service worker report a failure error and the done status of each goroutine within the service, use a single channel to have all service report on their status and completion.

Fixes #415
@gammazero gammazero marked this pull request as draft November 8, 2023 04:18
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (ead1a94) 74.10% compared to head (dfae0af) 74.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
+ Coverage   74.10%   74.26%   +0.16%     
==========================================
  Files         150      150              
  Lines        9876     9926      +50     
==========================================
+ Hits         7319     7372      +53     
+ Misses       1805     1802       -3     
  Partials      752      752              
Files Coverage Δ
service/datasetworker/statemonitor.go 82.45% <100.00%> (-1.99%) ⬇️
api/api.go 75.14% <90.00%> (+0.07%) ⬆️
service/contentprovider/bitswap.go 82.35% <83.33%> (-0.51%) ⬇️
service/contentprovider/http.go 67.30% <94.44%> (+2.11%) ⬆️
analytics/analytics.go 69.82% <50.00%> (-0.09%) ⬇️
service/datasetworker/datasetworker.go 79.43% <92.59%> (+0.97%) ⬆️
service/downloadserver/downloadserver.go 73.93% <91.66%> (+1.89%) ⬆️
service/healthcheck/healthcheck.go 78.88% <50.00%> (-0.88%) ⬇️
service/service.go 89.79% <84.37%> (+0.73%) ⬆️
service/dealpusher/dealpusher.go 76.57% <78.26%> (+2.32%) ⬆️
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammazero gammazero marked this pull request as ready for review November 8, 2023 16:26
@gammazero gammazero removed the request for review from xinaxu November 9, 2023 02:47
analytics/analytics.go Show resolved Hide resolved
@gammazero gammazero merged commit 56c253f into main Nov 9, 2023
12 checks passed
@gammazero gammazero deleted the consolidate-worker-channels branch November 9, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate service channels
2 participants