Fix function get_long_retweet. #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: after dataabc#575, there are actually no '原文转发' in the result of get_long_weibo, thus wb_content.rfind(u'原文转发') will always return -1. Now we can just use the same function get_long_weibo for both original weibo and retweets.
Owner
|
已合并，辛苦了。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在 #575 的改动之后，
get_long_weibo返回的结果里已不再包含 '原文转发'从而下面这行里的
wb_content.rfind(u'原文转发')会永远返回 -1:weiboSpider/weibo_spider/parser/comment_parser.py
Line 48 in 3cfdd76
现在对于长原创微博和长转发微博，我们可以使用相同的实现了。
同时更新了单元测试和单元测试所使用的数据（来自长转发微博 https://weibo.cn/comment/J5cVGuUNq ）