Skip to content

Conversation

@TCeason
Copy link
Collaborator

@TCeason TCeason commented Jan 13, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

query setting, session setting, set variable will not check privileges

fix: #17242

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

query setting, session setting, set variable will not check privileges
@TCeason TCeason marked this pull request as draft January 13, 2025 02:45
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Jan 13, 2025
@TCeason TCeason marked this pull request as ready for review January 13, 2025 03:26
@TCeason TCeason requested review from everpcpc and sundy-li January 13, 2025 03:26
@TCeason TCeason added this pull request to the merge queue Jan 13, 2025
Merged via the queue into databendlabs:main with commit e6cf9d1 Jan 13, 2025
85 checks passed
@TCeason TCeason deleted the set_priv branch January 13, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: session level set/unset setting do not need to check privilege

3 participants