Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backport): Backport replace into refactoring to v1.2.636 #17408

Draft
wants to merge 7 commits into
base: release/v1.2.636-rc8.3
Choose a base branch
from

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Feb 5, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

backports the following PRs to v1.2.636

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - backporting

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe): backporting

This change is Reviewable

…17355)

refactor: rename components of `replace into`

Initially, `REPLACE INTO` was designed as a simplified implementation of `MERGE INTO`, with the expectation that it would gradually evolve into a full-fledged implementation of `MERGE INTO`, as a result, many `MERGE INTO` related terms exist in the components of `REPLACE INTO` impl.

However, `MERGE INTO` now has its own independent impl, the remaining `MERGE INTO` related terms in the impl of `REPLACE INTO` can be misleading.

Therefore, in this PR, we have renamed all `MERGE INTO` related terms in the implof `REPLACE INTO` to avoid confusion.
* feat: introduce BlockMetaCache

* tweak sys tbl `system.cache` and configs

* cargo fmt

* update ut gloden file

* fix: set cache cap of `memory_cache_block_meta`
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Feb 5, 2025
@dantengsky dantengsky force-pushed the backport-refine-replace-into branch from 583243f to b71df62 Compare February 5, 2025 06:29
* test(stage): decouple `COPY INTO` tests from output data byte size

The tests should not assert the exact byte size of data outputs, as
this value may change across different versions of `databend-query`
due to meta data of data block contains the version the
`databend-query`, which is variant lengthed.

This change replaces byte size checks with content validation,
ensuring test stability while maintaining functional correctness.

* test(stage): decouple `COPY INTO` tests from output data byte size

* test(stage): decouple `COPY INTO` tests from output data byte size

* test(stage): decouple `COPY INTO` tests from output data byte size

* test(stage): decouple `COPY INTO` tests from output data byte size

* test(stage): decouple `COPY INTO` tests from output data byte size

* test(stage): decouple `COPY INTO` tests from output data byte size

* test(stage): decouple `COPY INTO` tests from output data byte size

05_0001_set_var.sh

* test(stage): decouple `COPY INTO` tests from output data byte size

18_0002_ownership_cover

* decouple `COPY INTO` tests from output data byte size

18_0007_privilege_access

* decouple `COPY INTO` tests from output data byte size

20_0015_compact_hook_stas_issue_13947

* decouple `COPY INTO` tests from output data byte size

* revert scripts/ci/deploy/config/databend-query-node-1.toml
ignore result-set of `copy into` when preparing data.
@dantengsky dantengsky force-pushed the backport-refine-replace-into branch from 49526ac to b4e9ef4 Compare February 6, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant